Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-262410

Brewing stand arms appear darker than they should


    • Confirmed
    • Rendering, Textures and models

      Finally time to get around to reporting this - I've been holding on to this one for a couple of years at this point. Closely related to MC-236474 (which is not a duplicate), MC-129826 and MC-214662.

      The bug

      The three arms that come off of brewing stands appear darker than they should due to the absence of '"shade": false' entries for these elements.

      This was originally reported under MC-68302. Since three cases of this have been split off into other tickets (MC-129826, MC-214662 and MC-236474), this is following suit, as it's fixable via models only (unlike the mushroom case, for example, which is reported under MC-248703 and is a rendering issue rather than a model issue).

      How to reproduce

      This can be done easily by comparing a brewing stand (clearest if bottles are present within) in 1.7.10 or earlier to one in 1.8 or later. The older brewing stand will correctly have the bottles appear bright, whereas in modern versions they appear dark.

      How to fix

      I have attached two resource packs to this ticket to fix this issue. The "45-degree fix" is the simplest one, and is designed to work with the current model. It functionally only changes the arm models to include the parameter that disables shading. I've also cleaned up the model code and added a missing cullface parameter to the middle rod.

      There is also a "60-degree fix", which rotates the arms to be at 120-degree angles from each other, which is another thing that changed in 1.8 (MC-257054). However, as Minecraft: Java Edition does not currently support rotation values in increments other than 22.5 degrees, the game's code will need to be modified to permit this. The screenshots of this model were taken in 1.16.1 using the ModelsUnlocked Fabric mod to permit this.

        1. 2023-05-07_08.53.38.png
          221 kB
        2. 2023-05-07_08.54.07.png
          235 kB
        3. 2023-05-07_09.24.24.png
          339 kB
        4. 2023-05-07_09.24.50.png
          338 kB
        5. 2023-05-07_09.25.04.png
          331 kB
        6. 2023-05-07_09.25.27.png
          331 kB
        7. 2023-05-07_09.29.53.png
          186 kB
        8. 2023-05-07_09.31.27.png
          196 kB
        9. brewing-stand-fix-45-degrees.zip
          4 kB
        10. brewing-stand-fix-60-degrees.zip
          4 kB

            Unassigned Unassigned
            Awesoman3000 Connor Steppie
            7 Vote for this issue
            4 Start watching this issue