Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-129826

["shade": false] is missing from potted cross models, resulting in most potted plants appearing darker than they should

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Resolution: Unresolved
    • Minecraft 1.12.2, Minecraft 18w20c, Minecraft 18w22a, Minecraft 18w22c, Minecraft 1.13-pre5, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 18w43a, Minecraft 18w43b, Minecraft 18w43c, Minecraft 18w47b, Minecraft 18w48a, Minecraft 18w48b, Minecraft 19w04b, Minecraft 19w05a, Minecraft 19w12b, Minecraft 19w13b, Minecraft 19w14a, Minecraft 19w14b, 1.14.4, 19w45a, 1.15.2, 20w15a, 1.16.3, 1.16.4, 20w51a, 21w03a, 21w05b, 21w06a, 21w07a, 21w10a, 21w11a, 21w13a, 21w14a, 21w16a, 1.17 Pre-release 1, 1.17 Pre-release 2, 1.17 Pre-release 3, 1.17, 1.17.1 Pre-release 1, 1.17.1, 21w39a, 21w40a, 21w42a, 1.18 Pre-release 1, 1.18, 1.18.1 Pre-release 1, 1.18.1, 22w06a, 1.18.2, 22w11a, 22w15a, 1.19 Pre-release 1, 1.19, 1.19.1 Pre-release 3, 1.19.2
    • None
    • Confirmed
    • Rendering
    • Low

    Description

      The bug

      When blocks were being converted over to using model files in 1.8, several of these conversions were incomplete and flawed, resulting in a multitude of issues. Many of these were resolved before the release of 1.8, however this specific issue was not.

      In 14w25a, models involving flat 2D planes had those planes be rendered darker depending on their directions. This affected blocks such as grass, flowers and mushrooms, and was ultimately fixed (MC-57159). However, the same version also caused plants in flower pots to appear darker for the same reason, and this was not fixed.

      As a result, plants which are placed in flower pots appear noticeably darker than those same plants when placed in the world (outside of a flower pot), which has been the case since 14w25a.

      A comparison of the appearances of potted objects can be found below:

      1.4.2 - 1.7.10 (expected rendering) 1.8 - present (incorrect rendering)

      How to fix

      This is ultimately incredibly easy to fix - the two texture plane elements in "flower_pot_cross.json" and its tinted version "tinted_flower_pot_cross.json" simply need a

      "shade": false

      line added to them, which should resolve this unwanted darkening.

      A comparison of potted objects with and without the fix can be found below:

      22w11a (current rendering) 22w11a (fixed rendering)

      Further notes

      22w11a implemented potted mangrove propagules, which are completely unaffected by this issue as they have a unique, dedicated model which does actually explicitly disable shading. Despite this, shading was not disabled for existing potted crosses in this version.

      Attachments

        1. 2022-03-18_22.52.40.png
          2022-03-18_22.52.40.png
          158 kB
        2. 2022-03-18_23.11.29.png
          2022-03-18_23.11.29.png
          87 kB
        3. 2022-03-18_23.12.42.png
          2022-03-18_23.12.42.png
          109 kB
        4. 2022-03-19_14.53.34.png
          2022-03-19_14.53.34.png
          300 kB
        5. 2022-03-19_14.54.12.png
          2022-03-19_14.54.12.png
          301 kB
        6. Corrected Flower Pots.png
          Corrected Flower Pots.png
          186 kB
        7. Current Flower Pots.png
          Current Flower Pots.png
          188 kB
        8. flower_pot_cross.json
          3 kB
        9. flower pots.jpg
          flower pots.jpg
          22 kB
        10. flower pots fix.zip
          2 kB
        11. tinted_flower_pot_cross.json
          3 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Awesoman3000 Connor Steppie
              Votes:
              22 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                CHK: