Testing discovered MC-236456 - remove this line once the issue has been linked

The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.

Download resource pack:

• 1.17.1: consistent-crosses-1.17.1-v1.0.zip

The bug

The cross block model, which is functionally a template model due to only containing the block shape and being referenced by other models to apply textures, is not prefixed with "template_". This is unlike a multitude of other template models which the game uses, which are in fact prefixed with "template_".

Various other models closely related to the cross model are also subject to this issue.

How to reproduce

This is as easy as just navigating to the assets/minecraft/models/block directory and checking the file names.

1. Open the game jar file using one's preferred method
2. Check the model file of a block that uses the cross model, such as dandelion.json
   1. Note that it references block/cross.json, and also note that it isn't prefixed with template_
3. Check the model of a block such as a wall torch, anvil, chorus flower, ...
   1. Note that the model it references is prefixed with template_ due to the referenced model in question being a template model

Expected and actual results

The table below summarizes the expected file names for the models in question.

How to fix

Fixing this is as simple as renaming the five affected model files above, and then repointing all model files that reference them to the new names. While this may seem to be a laborious task due to this affecting over 100 model files, the attached resource pack already fixes every affected model in the game, meaning that vanilla's assets can be simply replaced with these instead in a matter of seconds.

The pack also cleans up formatting for consistency, and comes with two bonus fixes:

• MC-203406 and MC-236456 - Kelp and bamboo shoots now reference (template_)cross instead of (template_)tinted_cross due to not using biome tints normally
• MC-129826 - Potted plants now appear bright like when placed in the world, rather than appearing darkened