Resolution: Cannot Reproduce
Minecraft 1.11.2, Minecraft 1.13, Minecraft 1.13.1-pre2, Minecraft 1.13.1, 1.15, 1.15.2, 1.16 Release Candidate 1, 1.16, 20w27a, 1.16.2 Pre-release 1, 1.16.2 Release Candidate 2, 1.16.2, 1.16.3, 20w48a, 20w49a, 1.16.5, 1.17 Pre-release 1, 1.17, 1.17.1, 21w39a, 21w44a
When there are extreme numbers of block entities (even non-ticking) a lot of time can be spent unloading them from a list in the world. This happens when you have a huge number of block entities and leave the area.
- Create a new superflat world and /tp 0 ~ 0
- Create a lot of block entities spread over a few chunks: /fill 0 ~ 0 100 ~2 100 minecraft:furnace
- Fly away, witness huge lag spikes when block entities begin to be unloaded
Sampling results looks like this: list.png
Several fields in World.java use List methods with very bad time complexity.
These fields are using add, remove, removeAll, and iterators:
After replacing those two Lists with Set, there is no lag spike and the sampling results look much better: set.png
After discussing this with others, we think the best solution is to break up these lists so they are indexed by chunk.
That way, an unloaded chunk can just drop its ticking list and there is no slow remove on a giant list.
It could also make finding nearby entities more efficient.