Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-96426

Potions and tipped arrows with effect which has ShowParticles set to 0b has incorrect color (black)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 16w04a, Minecraft 1.9, Minecraft 16w14a, Minecraft 1.10.2, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b, Minecraft 16w39c, Minecraft 16w40a, Minecraft 16w41a, Minecraft 16w42a, Minecraft 16w43a, Minecraft 16w44a, Minecraft 1.11, Minecraft 16w50a, Minecraft 1.11.1, Minecraft 1.11.2, Minecraft 17w06a, Minecraft 17w13b, Minecraft 17w15a, Minecraft 17w16b, Minecraft 17w17a, Minecraft 17w18b, Minecraft 1.12 Pre-Release 2, Minecraft 1.12.2, Minecraft 18w15a, Minecraft 1.13.1
    • Fix Version/s: None
    • Confirmation Status:
      Confirmed
    • Category:
      (Unassigned)

      Description

      The bug

      A potion with a potion effect that has ShowParticles set to 0b uses always the same color no matter what potion effect is used.

      How to reproduce

      1. Use the following command to give yourself a potion with ShowParticles:1b
        /give @p potion{CustomPotionEffects:[{Id:1b,ShowParticles:1b}],Potion:"minecraft:water"}
        
      2. Use the following command to give yourself a potion with ShowParticles:0b
        /give @p potion{CustomPotionEffects:[{Id:1b,ShowParticles:0b}],Potion:"minecraft:water"}
        

      The reason

      The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

      The reason why this happens is that the method net.minecraft.potion.PotionUtils.func_185181_a(Collection<PotionEffect>) only calculates the color if the effect shows particles. This is done that way because the value 0 is used to indicate that no particles should be created. A third value should probably be added to indicate whether particle effects should be displayed or not. Another way to solve this could be to have one byte value instead of a boolean for whether or not the particles are ambient which stores a value representing the state, for example:

      Value State
      0 No particles
      1 Particles
      2 Ambient particles
      Affected methods
      • net.minecraft.entity.EntityLivingBase.updatePotionEffects()
      • net.minecraft.client.renderer.entity.RenderTippedArrow.getEntityTexture(EntityTippedArrow)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                marcono1234 [Mod] Marcono1234
              • Votes:
                10 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: