Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-261387

Redundant block_predicate_filter check in mangrove tree placement

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 1.19.4, 23w12a, 1.20.1, 23w32a, 1.20.4, 24w03b
    • None
    • Confirmed
    • World generation

      Mangrove tree placement runs two block_predicate_filter checks for each placement, which is redundant as if the first one passes the second one will be guaranteed to pass.

      The Mangrove Swamp biome references the trees_mangrove placed feature, which does the usual stuff with tree placement (increase count, randomize placement in chunk, adjust to heightmap, check for biome), but it also runs a block_predicate_filter to check that a Mangrove Propagule can survive at the given location. This placed feature then references the mangrove_vegetation configured feature, which chooses to either place theĀ mangrove_checked or tall_mangrove_checked placed feature. Both of these placed features run their own block_predicate_filter to check that a Mangrove Propagule can survive at that location for no reason.

      Attached are the JSON files for all of the referenced configured and placed features, taken directly from 1.19.4's jar file.

        1. mangrove_checked.json
          0.4 kB
        2. mangrove_vegetation.json
          0.2 kB
        3. tall_mangrove_checked.json
          0.4 kB
        4. trees_mangrove.json
          0.8 kB

            Unassigned Unassigned
            LegoEmmetMC Apollo
            Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              CHK: