Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-258242

Checkerboard biome sources using biome tags do not generate features, and structures cannot be /located


    • Icon: Bug Bug
    • Resolution: Fixed
    • 1.19.4 Pre-release 1
    • 1.19.2, 1.19.3 Release Candidate 1
    • None
    • Confirmed
    • Custom Worlds, Data Packs, World generation
    • Low
    • Platform

      The attached datapack overrides the overworld dimension to use a checkerboard biome source that uses all biomes in the "#is_overworld" biome tag.

      When using this datapack, the dimension json is able to be read and loaded and the overworld correctly uses a checkerboard biome source using all overworld biomes; however, no features in the biomes generate.

      Structures generate but cannot be located with the /locate command.

      Analysis of the decompiled source code indicates that this happens because the BiomeSource base class's constructor forces biome sources to provide a list of biomes when the dimension is constructed; this happens before tags are bound to tag holdersets, so this list is empty for checkerboard biome sources when a tag is specified.

      The checkerboard biome source overrides some biome querying to correctly evaluate the biome tag rather than the initial (empty) list, but not all biome queries, resulting in the screenshots above where the terrain for the biomes generates but their placed features do not.

        1. 2023-02-26_10.57.43.png
          4.22 MB
        2. 2023-02-26_10.57.50.png
          5.15 MB
        3. 2023-02-26_10.58.35.png
          1.71 MB
        4. CheckerBoardBiomeTag.zip
          1.0 kB
        5. image-2022-12-01-19-07-01-307.png
          391 kB
        6. screenshot-1.png
          531 kB

            Unassigned Unassigned
            Commoble Commoble
            6 Vote for this issue
            4 Start watching this issue