Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-214686

Wall torch template model is called "template_torch_wall.json"


    • Icon: Bug Bug
    • Resolution: Invalid
    • None
    • 1.16.5, 21w05b, 1.17.1, 1.19
    • Confirmed
    • Textures and models

      The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.

      Download resource pack:

      The bug

      The template model used for wall torches is called "template_torch_wall.json". This name is inconsistent and unintuitive - all of the model sthat actually refer to this template are called "wall_torch.json" and similar such terms, and the IDs of the blocks which use these models are also called "wall_torch" and similar.

      How to reproduce

      1. Extract the minecraft.jar file by one's preferred method
      2. Navigate to assets/minecraft/models/block
      3. Locate wall_torch.json
      4. Note that the template it references is called template_torch_wall.json, rather than template_wall_torch.json.

      Expected result

      The template model would be called something like tempalte_wall_torch.json to be consistent with those that use it.

      Actual result

      The template model is called template_torch_wall.json, completely defying the expected name order.

      How to fix

      The resource pack attached fixes a substantial amount of issues with torches. As well as resolving this naming quirk, it fixes all of the following problems:

      • (1.0+) MC-109087 (partially) - The bottom faces of floor torches are now culled against solid blocks
      • (1.1+) MC-177452 - Several faces which are never visible under normal circumstances have been removed from repeaters
      • (1.1+) MC-177453 - Several faces which are never visible under normal circumstances have been removed from comparators
      • (1.0+) MC-214625 - Unlit redstone torches are now shaded differently per side to match other non-light-emitting cuboids
      • (1.1+) MC-214662 - Lit torches on redstone repeaters and comparators are no longer shaded depending on direction
      • (1.0+) The wall torch template model has been changed to face south by default rather than east, to alleviate confusion
      • (1.1+) Ambient occlusion has been re-enabled for inactive redstone repeaters and comparators

      In addition, formatting has been fixed for all of the models to improve readability and for consistency.

      A resource pack which exclusively fixes the naming issue can be attached upon request, however I'd strongly recommend fixing all of these other issues as well, as it comes at no extra time or labor cost.

            Unassigned Unassigned
            Awesoman3000 Connor Steppie
            3 Vote for this issue
            6 Start watching this issue