Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-197263

End sky and nether fog don't work on servers

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 1.16.2 Pre-release 3
    • None
    • Community Consensus
    • Rendering
    • Very Important

    Description

      The custom sky textures don't work on Pre-3 Vanilla servers (servers, not singleplayer!).

       

      The class 'ClientLevel' gets the effect through:

      this.effects = DimensionSpecialEffects.forType(dwm.registryAccess().dimensionTypes().getResourceKey(cha));
      

      which used the dimension data sent in Login and Respawn packets to get the dimension key resource location, but this doesn't properly resolve since 'DimensionType' does not implement hashCode or equals (this works on singleplayer due to them just being the same instance).

       

      Possible solution: Either send the resource location in Login and Respawn or implement hashCode/equals in DimensionType (the first of which would be preferred for certain modmakers tho)

      Attachments

        1. acmVQXS.jpg
          353 kB
          Nassim
        2. NAiBVU6.png
          482 kB
          Nassim

        Issue Links

          Activity

            People

              slicedlime [Mojang] slicedlime
              KennyTV Nassim
              Votes:
              5 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                CHK: