-
Bug
-
Resolution: Unresolved
-
None
-
Minecraft 1.12.2, Minecraft 1.13, Minecraft 18w30a, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 18w43b, Minecraft 18w43c, Minecraft 18w44a, Minecraft 18w45a, 1.14.4, 1.15 Pre-release 1, 1.16.3, 20w51a, 21w15a, 1.17 Pre-release 1, 1.17 Pre-release 5, 1.17.1, 21w39a, 1.18.1 Release Candidate 2, 1.20.2
-
Confirmed
-
Rendering
-
Low
-
Gameplay
The bug
It is impossible for a block in the game to be fully white, the brightest color is 0xFCFCFC.
Disabling ambient occlusion or shading on the block model doesn't fix this.
How to reproduce
- Load MC-123703(unzip).zip texture pack into the game.
- Take a screenshot, and get the color of the the glowstone block.
→ You'll notice that the color code is 0xFCFCFC rather than 0xFFFFFF.
Code analysis / Fix
This is caused by lines 911-913 and 984-986 of the EntityRenderer (MCP name) class:
f8 = f8 * 0.96F + 0.03F; f9 = f9 * 0.96F + 0.03F; f10 = f10 * 0.96F + 0.03F;
Which sets red, green, and blue to 0.99 (0xFCFCFC) even if they were 1.