Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-120558

Advancement trigger consume_item not working for single potion item stack

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 1.12, Minecraft 1.12.1, Minecraft 1.12.2 Pre-Release 1, Minecraft 1.12.2 Pre-Release 2, Minecraft 1.12.2, Minecraft 17w43b, Minecraft 17w45a, Minecraft 17w46a, Minecraft 17w48a, Minecraft 17w50a, Minecraft 18w01a, Minecraft 18w03b, Minecraft 18w05a, Minecraft 18w06a, Minecraft 18w09a, Minecraft 18w14b, Minecraft 1.13-pre1, Minecraft 1.13-pre3, Minecraft 1.13-pre6, Minecraft 1.13-pre8, Minecraft 1.13-pre10, Minecraft 1.13, Minecraft 18w30b, Minecraft 18w31a, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 19w08b, Minecraft 19w09a, Minecraft 19w11a, Minecraft 19w11b
    • Fix Version/s: None
    • Confirmation Status:
      Confirmed
    • Game Mode:
      Survival
    • Category:
      (Unassigned)

      Description

      The bug

      The advancement trigger consume_item is not working for single potion item stacks when consumed in Survival or Adventure mode.

      How to reproduce

      1. Download the attached data pack MC-120558 data pack.zip and place it in the datapacks folder of your world
      2. Open the world and drink any potion in Survival mode
        The advancement is not granted
      3. Drink any potion in Creative mode
        The advancement is granted as expected

      Code analysis

      Based on 1.12.2 decompiled using MCP 9.40

      The method net.minecraft.item.ItemPotion.onItemUseFinish(ItemStack, World, EntityLivingBase) reduces the stack size before applying the potion effects and testing advancement triggers. Therefore when the triggers are tested 0*potion (acting like 0*air) is compared.

      Reducing the stack size should probably happen right before the glass bottle is added to the inventory.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                AnnoyDog Tristan Hudson
              • Votes:
                12 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: