<!-- 
RSS generated by JIRA (9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13) at Sun Jan 12 12:22:34 UTC 2025

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Mojang Studios Jira</title>
    <link>https://bugs.mojang.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en</language>    <build-info>
        <version>9.12.2</version>
        <build-number>9120002</build-number>
        <build-date>10-01-2024</build-date>
    </build-info>


<item>
            <title>[MC-9886] Maps in item frames cause un-necessary lag </title>
                <link>https://bugs.mojang.com/browse/MC-9886</link>
                <project id="10400" key="MC">Minecraft: Java Edition</project>
                    <description>&lt;p&gt;Currently, EntityTrackerEntry.track when sending map data for item frames is sending the data to all players in the same world.&lt;/p&gt;

&lt;p&gt;Theres 2 issues:&lt;br/&gt;
1) The code is using the supplied &quot;list&quot; parameter passed to .track() which includes every player in the current world.&lt;/p&gt;

&lt;p&gt;It should actually be using this.trackedPlayers, so that only players in range of the itemframe will receive the data.&lt;/p&gt;

&lt;p&gt;2) It is checking the low priority queue for load, which is not used anymore so will always be true.&lt;/p&gt;

&lt;p&gt;So on a large server, a single user can setup a large number of maps in item frames and totally destroy the servers performance as it spams the map data to every player in the world.&lt;/p&gt;

&lt;p&gt;The main issue can be fixed by simply with CraftBukkit naming:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;diff --git a/src/main/java/net/minecraft/server/EntityTrackerEntry.java b/src/main/java/net/minecraft/server/EntityTrackerEntry.java
index c629046..f482f34 100644
--- a/src/main/java/net/minecraft/server/EntityTrackerEntry.java
+++ b/src/main/java/net/minecraft/server/EntityTrackerEntry.java
@@ -80,7 +80,7 @@ &lt;span class=&quot;code-keyword&quot;&gt;public&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;class &lt;/span&gt;EntityTrackerEntry {
 
             &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (i5 != &lt;span class=&quot;code-keyword&quot;&gt;null&lt;/span&gt; &amp;amp;&amp;amp; i5.getItem() &lt;span class=&quot;code-keyword&quot;&gt;instanceof&lt;/span&gt; ItemWorldMap) {
                 WorldMap i7 = Item.MAP.getSavedMap(i5, &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.tracker.world);
-                Iterator j0 = list.iterator();
+                Iterator j0 = &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.trackedPlayers.iterator(); &lt;span class=&quot;code-comment&quot;&gt;// CraftBukkit - Only send to players in range&lt;/span&gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
</description>
                <environment></environment>
        <key id="23648">MC-9886</key>
            <summary>Maps in item frames cause un-necessary lag </summary>
                <type id="1" iconUrl="https://bugs.mojang.com/secure/viewavatar?size=xsmall&amp;avatarId=18903&amp;avatarType=issuetype">Bug</type>
                                    <status id="5" iconUrl="https://bugs.mojang.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="3">Duplicate</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="aikar">Aikar</reporter>
                        <labels>
                    </labels>
                <created>Sat, 16 Feb 2013 15:59:02 +0100</created>
                <updated>Mon, 3 Mar 2014 08:55:14 +0100</updated>
                            <resolved>Sun, 15 Dec 2013 03:42:30 +0100</resolved>
                                    <version>Minecraft 1.4.7</version>
                    <version>Snapshot 13w10b</version>
                    <version>Minecraft 1.5</version>
                                                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                            <comments>
                            <comment id="125144" author="aikar" created="Sun, 15 Dec 2013 05:57:53 +0100"  >&lt;p&gt;This was not a duplicate of that issue, but this is likely improved slightly in 1.7.&lt;/p&gt;</comment>
                            <comment id="121470" author="talven81" created="Tue, 26 Nov 2013 22:05:26 +0100"  >&lt;p&gt;Is this still a concern in the &lt;em&gt;current Minecraft version&lt;/em&gt; &lt;b&gt;1.7.2&lt;/b&gt; / Launcher version &lt;b&gt;1.3.4&lt;/b&gt; ? If so, please &lt;em&gt;update the affected versions&lt;/em&gt; in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.&lt;/p&gt;</comment>
                            <comment id="47894" author="cubethethird" created="Wed, 27 Feb 2013 03:18:55 +0100"  >&lt;p&gt;I will re-open this, however note that all issues have the same priority, and this cannot be changed.&lt;/p&gt;</comment>
                            <comment id="47665" author="aikar" created="Tue, 26 Feb 2013 15:19:21 +0100"  >&lt;p&gt;I contributed to the Spigot project with this fix, and multiple server owners are now running this slightly modified (to only send the map once) with great results.&lt;/p&gt;

&lt;p&gt;Previously this issue was tearing servers apart.&lt;/p&gt;

&lt;p&gt;It needs to be fixed ASAP before its wide spread to the public that you can take down servers and waste massive amounts of bandwidth with very little effort.&lt;/p&gt;</comment>
                            <comment id="47664" author="aikar" created="Tue, 26 Feb 2013 15:17:22 +0100"  >&lt;p&gt;Also, I have found another issue in the code.&lt;/p&gt;

&lt;p&gt;The boolean logic for the &quot;is an item frame and once every 10 ticks&quot; is broken.&lt;/p&gt;

&lt;p&gt;The update counter is never incremented, so this code will run EVERY tick, not one in ten.&lt;/p&gt;

&lt;p&gt;The code needs to look something like this:&lt;/p&gt;


&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.tracker &lt;span class=&quot;code-keyword&quot;&gt;instanceof&lt;/span&gt; EntityItemFrame) {
            EntityItemFrame i4 = (EntityItemFrame) &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.tracker;
            ItemStack i5 = i4.i();

            &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.m++ % 10 == 0 &amp;amp;&amp;amp; i5 != &lt;span class=&quot;code-keyword&quot;&gt;null&lt;/span&gt; &amp;amp;&amp;amp; i5.getItem() &lt;span class=&quot;code-keyword&quot;&gt;instanceof&lt;/span&gt; ItemWorldMap &amp;amp;&amp;amp; &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.trackedPlayers.size() &amp;gt; 0) {
                 WorldMap i7 = Item.MAP.getSavedMap(i5, &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.tracker.world);
                 Iterator j0 = &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.trackedPlayers.iterator(); 
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Id also recommend lowering the default itemframe tracking range so that so many people arent tracking them so far away.... at distances they cant even see the things really.&lt;/p&gt;
</comment>
                            <comment id="47663" author="aikar" created="Tue, 26 Feb 2013 15:12:25 +0100"  >&lt;p&gt;I did, this is not a duplicate. Please reopen and raise the priority of this.&lt;/p&gt;

&lt;p&gt;This issue has nothing to do with that issue. This is a server issue, that is a client issue.&lt;/p&gt;

&lt;p&gt;This needs to be fixed for 1.5 so please open and get it pushed to proper people ASAP.&lt;/p&gt;</comment>
                            <comment id="47659" author="cubethethird" created="Tue, 26 Feb 2013 14:07:38 +0100"  >&lt;p&gt;Duplicate of &lt;a href=&quot;https://bugs.mojang.com/browse/MC-1138&quot; title=&quot;Item frames cause lag / huge FPS drops when rendered&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-1138&quot;&gt;&lt;del&gt;MC-1138&lt;/del&gt;&lt;/a&gt;. Please use the search function to check before posting in the future.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10102">
                    <name>Duplicate</name>
                                            <outwardlinks description="duplicates">
                                        <issuelink>
            <issuekey id="12447">MC-1138</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                        <customfield id="customfield_10500" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Confirmation Status</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10300"><![CDATA[Unconfirmed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_11700" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_11100" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Linked</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_11600" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0a193:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>