<!-- 
RSS generated by JIRA (9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13) at Sun Jan 12 11:50:53 UTC 2025

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Mojang Studios Jira</title>
    <link>https://bugs.mojang.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en</language>    <build-info>
        <version>9.12.2</version>
        <build-number>9120002</build-number>
        <build-date>10-01-2024</build-date>
    </build-info>


<item>
            <title>[MC-398] Structures generating in wrong biomes</title>
                <link>https://bugs.mojang.com/browse/MC-398</link>
                <project id="10400" key="MC">Minecraft: Java Edition</project>
                    <description>&lt;p&gt;The desert temples should only spawn in desert biomes but this one spawned in a swamp biome.&lt;/p&gt;
&lt;hr /&gt;
&lt;p&gt;Update&lt;/p&gt;

&lt;p&gt;It appears that these temples could be spawning instead of other structures e.g. witch huts in swamps and jungle temples in jungles.&lt;/p&gt;

&lt;p&gt;WHEN POSTING AN IMAGE PLEASE INCLUDE COORDINATES AND SEED&lt;/p&gt;</description>
                <environment>Windows 7 64bit&lt;br/&gt;
Java version 7&lt;br/&gt;
World created in 1.4 pre&lt;br/&gt;
Chunks generated in 1.4.2</environment>
        <key id="11662">MC-398</key>
            <summary>Structures generating in wrong biomes</summary>
                <type id="1" iconUrl="https://bugs.mojang.com/secure/viewavatar?size=xsmall&amp;avatarId=18903&amp;avatarType=issuetype">Bug</type>
                                    <status id="5" iconUrl="https://bugs.mojang.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="khonka">Ben H-W</reporter>
                        <labels>
                            <label>biome</label>
                            <label>structure</label>
                            <label>world-generation</label>
                    </labels>
                <created>Thu, 25 Oct 2012 12:25:03 +0200</created>
                <updated>Fri, 14 Aug 2020 20:18:46 +0200</updated>
                            <resolved>Wed, 31 Oct 2012 14:32:12 +0100</resolved>
                                    <version>Minecraft 1.4.2</version>
                                    <fixVersion>Minecraft 1.4.3</fixVersion>
                                                        <votes>11</votes>
                                    <watches>2</watches>
                                                                            <comments>
                            <comment id="17221" author="eggz123" created="Fri, 2 Nov 2012 17:31:45 +0100"  >&lt;p&gt;that jungle temple looks so weird XD oh and i got a bug for ya FIX THE FRICKIN GENERATION ERRORS!!!!&lt;/p&gt;</comment>
                            <comment id="16819" author="shaylynarchuleta" created="Fri, 2 Nov 2012 00:16:58 +0100"  >&lt;p&gt;Aww no.....I loved this bug.... &lt;img class=&quot;emoticon&quot; src=&quot;https://bugs.mojang.com/images/icons/emoticons/sad.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="15828" author="jeb" created="Wed, 31 Oct 2012 14:32:12 +0100"  >&lt;p&gt;Temples and huts are now more strictly placed in correct biomes. I haven&apos;t looked at placement of villages, please create a separate bug report for that.&lt;/p&gt;</comment>
                            <comment id="15324" author="dieval" created="Tue, 30 Oct 2012 08:34:40 +0100"  >&lt;p&gt;As far as I know, there isn&apos;t.&lt;/p&gt;</comment>
                            <comment id="15242" author="dgreentheawesome" created="Tue, 30 Oct 2012 00:32:23 +0100"  >&lt;p&gt;Is there a structure ID list? Could the game try and generate &quot;1&quot; (a village) in the correct place, but end up with &quot;2&quot;, a temple (just an example)? Maybe the NPC villages in &quot;wth&quot; and &quot;wth2&quot; should have been strongholds.&lt;/p&gt;</comment>
                            <comment id="14849" author="dieval" created="Sun, 28 Oct 2012 23:13:28 +0100"  >&lt;p&gt;Found one problem with villages. But it&apos;s also only happening on biome borders, and couldn&apos;t cause the village in wth2.png. There must be something else that I can&apos;t find.&lt;/p&gt;</comment>
                            <comment id="14650" author="dieval" created="Sun, 28 Oct 2012 09:31:46 +0100"  >&lt;p&gt;@Timothy Cachia&lt;br/&gt;
Can you give me the seed and coordinates?&lt;/p&gt;


&lt;p&gt;Looking into villages now.&lt;/p&gt;</comment>
                            <comment id="14630" author="khonka" created="Sun, 28 Oct 2012 06:48:52 +0100"  >&lt;p&gt;Congrats it appears that the mod fix by DiEvAl has fixed the problem!! Checked seed: 6837862977289291133 x-cords: -660 z-cords:521 for temple and it wasn&apos;t there check out the image attached.&lt;/p&gt;</comment>
                            <comment id="14537" author="takomt" created="Sun, 28 Oct 2012 00:00:45 +0200"  >&lt;p&gt;You sure DiEvAl? I found structures (incorrectly spawned) in one single biome. For example in the middle of the ocean surround by nothing but ocean.&lt;/p&gt;

&lt;p&gt;Also, the bug is effecting all structures including villages... not just temples.&lt;/p&gt;</comment>
                            <comment id="14535" author="dieval" created="Sat, 27 Oct 2012 23:52:43 +0200"  >&lt;p&gt;I made a mod that is supposed to fix desert temples generating instead of witch huts and jungle temples. I added it as attachment.&lt;/p&gt;

&lt;p&gt;@mojang I replaced this code:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; world.getChunkManager().areBiomesViable(chunkX * 16 + 8, chunkZ * 16 + 8, 0, biomeList);&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;with this code:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; biomeList.contains(world.getBiomeGenForCoords(chunkX * 16 + 8, chunkZ * 16 + 8));&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;It looks like world.getChunkManager().areBiomesViable(x, z, 0, biomeList) checks slightly different block(s) than&lt;br/&gt;
world.getBiomeGenForCoords(x, z). So when (x,z) is near the biome border, they return different results. Not sure why.&lt;/p&gt;


&lt;p&gt;Also I replaced this (pseudocode incoming!):&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;biome = world.getBiomeGenForCoords(chunkX * 16 + 8, chunkZ * 16 + 8);
&lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (biome == jungleHills || biome == jungle) {
    &lt;span class=&quot;code-comment&quot;&gt;// jungle temple
&lt;/span&gt;} &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (biome == swampland) {
    &lt;span class=&quot;code-comment&quot;&gt;// witch hut
&lt;/span&gt;} &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; {
    &lt;span class=&quot;code-comment&quot;&gt;// desert temple
&lt;/span&gt;}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;with this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;biome = world.getBiomeGenForCoords(chunkX * 16 + 8, chunkZ * 16 + 8);
&lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (biome == jungleHills || biome == jungle) {
    &lt;span class=&quot;code-comment&quot;&gt;// jungle temple
&lt;/span&gt;} &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (biome == swampland) {
    &lt;span class=&quot;code-comment&quot;&gt;// witch hut
&lt;/span&gt;} &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (biome == desertHills || biome == desert) {
    &lt;span class=&quot;code-comment&quot;&gt;// desert temple
&lt;/span&gt;} &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; {
    &lt;span class=&quot;code-comment&quot;&gt;// bug!
&lt;/span&gt;}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;This last change is not required of course.&lt;/p&gt;</comment>
                            <comment id="14521" author="takomt" created="Sat, 27 Oct 2012 22:46:16 +0200"  >&lt;p&gt;The problem is on every structure... witch hut, temple. villages, etc...&lt;/p&gt;

&lt;p&gt;Posted one earlier on regarding a village and temple spawning the middle of a desert.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://mojang.atlassian.net/browse/MC-934&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://mojang.atlassian.net/browse/MC-934&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="14515" author="dieval" created="Sat, 27 Oct 2012 22:33:23 +0200"  >&lt;p&gt;I have an idea why this might be happening. If my idea is true, then structure is a desert pyramid if and only if both statements are true:&lt;br/&gt;
1) center of a structure is &lt;b&gt;not&lt;/b&gt; in one of the following biomes: desertHills, jungle, jungleHills, swampland.&lt;br/&gt;
2) structure near one of the following biomes: desert, desertHills, jungle, jungleHills, swampland.&lt;br/&gt;
Can anyone confirm or disprove this?&lt;/p&gt;

&lt;p&gt;EDIT: My idea was not exactly correct. I found a pyramid with center in the swamp, but some parts in the river. But it looks like it always happens near the border of 2 or more biomes such that one biome is &lt;b&gt;neither&lt;/b&gt; desertHills, jungle, jungleHills &lt;b&gt;nor&lt;/b&gt; swampland and another is desert, desertHills, jungle, jungleHills &lt;b&gt;or&lt;/b&gt; swampland.&lt;/p&gt;</comment>
                            <comment id="14503" author="dieval" created="Sat, 27 Oct 2012 21:59:46 +0200"  >&lt;p&gt;Confirmed.&lt;br/&gt;
Seed: -5101227880727282991&lt;br/&gt;
x: -760&lt;br/&gt;
z: 700&lt;br/&gt;
Border of jungle and plains.&lt;br/&gt;
Probably it&apos;s supposed to be a jungle temple.&lt;/p&gt;</comment>
                            <comment id="14314" author="richardcox13" created="Sat, 27 Oct 2012 11:09:12 +0200"  >&lt;p&gt;I&apos;m starting to think my problem with desert temples not in deserts is not so much the location, but that the use of sandstone does not fit.&lt;/p&gt;

&lt;p&gt;If desert temples do occur in other biomes their principle material should reflect where they are. So temples in jungles would be made of (say) cobblestone but in swamps they are (say) stone.&lt;/p&gt;</comment>
                            <comment id="14245" author="ledrewxcore" created="Sat, 27 Oct 2012 03:57:18 +0200"  >&lt;p&gt;Found these in jungles and swamps, seem to be replacing other generated structures. This is happening not only on single player worlds but also on SMP worlds. &lt;/p&gt;

&lt;p&gt;Uploaded another picture of a temple spawned in a Jungle biome. It does overlap to the Taiga in the background however the centre is located in the jungle.&lt;/p&gt;</comment>
                            <comment id="13814" author="mgt98" created="Fri, 26 Oct 2012 05:47:46 +0200"  >&lt;p&gt;Related topic? &lt;a href=&quot;https://mojang.atlassian.net/browse/MC-659&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://mojang.atlassian.net/browse/MC-659&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="13266" author="richardcox13" created="Thu, 25 Oct 2012 17:27:57 +0200"  >&lt;p&gt;@Paul: I agree there is a logic here (obviously), however the defect is in that logic.&lt;/p&gt;

&lt;p&gt;A beach (especially a beach beside a river) should not &lt;span class=&quot;error&quot;&gt;&amp;#91;IMHO&amp;#93;&lt;/span&gt; qualify as enough of a desert for desert structures. This does not seem to be a problem for desert villages or desert wells (or maybe I have not looked around enough &lt;img class=&quot;emoticon&quot; src=&quot;https://bugs.mojang.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;).&lt;/p&gt;</comment>
                            <comment id="13258" author="kaizenneko" created="Thu, 25 Oct 2012 17:18:23 +0200"  >&lt;p&gt;In the first screenshot, the temple is actually in 2 biomes: River &amp;amp; Jungle. Poking around inside, it seemed to have been actually spawned the river biome. I&apos;d look around the Swamp one and see if there is a river there as well. I have a hunch the temple spawn generation is seeing rivers as a valid desert to place them.&lt;/p&gt;</comment>
                            <comment id="13235" author="jonatkins" created="Thu, 25 Oct 2012 16:40:04 +0200"  >&lt;p&gt;Confirmed. Attached is a screenshot of one in a jungle. &lt;/p&gt;

&lt;p&gt;Fresh world created in 1.4.2, seed and coordinates shown.&lt;/p&gt;</comment>
                            <comment id="13090" author="arokip" created="Thu, 25 Oct 2012 12:31:52 +0200"  >&lt;p&gt;Confirmed, I had two desert temples in jungle and one of them was under ground. It happened already in 1.3.1&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10102">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="11936">MC-659</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="12104">MC-824</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="12226">MC-934</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="10885" name="2012-10-25_15.35.41.png" size="2002546" author="jonatkins" created="Thu, 25 Oct 2012 16:40:04 +0200"/>
                            <attachment id="10840" name="2012-10-25_18.17.39.png" size="1454793" author="khonka" created="Thu, 25 Oct 2012 12:25:03 +0200"/>
                            <attachment id="11115" name="2012-10-26_23.17.11.png" size="672048" author="ledrewxcore" created="Sat, 27 Oct 2012 03:53:10 +0200"/>
                            <attachment id="11220" name="2012-10-28_13.44.50.png" size="1945345" author="khonka" created="Sun, 28 Oct 2012 06:50:45 +0100"/>
                            <attachment id="11198" name="MC-398-fix.zip" size="2681" author="dieval" created="Sat, 27 Oct 2012 23:52:39 +0200"/>
                            <attachment id="11232" name="witchhutdesert.png" size="1346535" author="takomt" created="Sun, 28 Oct 2012 09:11:35 +0100"/>
                            <attachment id="11225" name="wth.png" size="2888250" author="takomt" created="Sun, 28 Oct 2012 07:46:16 +0100"/>
                            <attachment id="11226" name="wth2.png" size="2751507" author="takomt" created="Sun, 28 Oct 2012 07:47:47 +0100"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                        <customfield id="customfield_10500" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Confirmation Status</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10300"><![CDATA[Unconfirmed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_11700" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_11100" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Linked</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_11600" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0m18f:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>