<!-- 
RSS generated by JIRA (9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13) at Sun Jan 12 12:26:53 UTC 2025

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Mojang Studios Jira</title>
    <link>https://bugs.mojang.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en</language>    <build-info>
        <version>9.12.2</version>
        <build-number>9120002</build-number>
        <build-date>10-01-2024</build-date>
    </build-info>


<item>
            <title>[MC-11208] The big tree generator handles tree height variable incorrectly</title>
                <link>https://bugs.mojang.com/browse/MC-11208</link>
                <project id="10400" key="MC">Minecraft: Java Edition</project>
                    <description>&lt;p&gt;(Relates to &lt;a href=&quot;https://bugs.mojang.com/browse/MC-10534&quot; title=&quot;Big oak trees don&amp;#39;t spawn&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-10534&quot;&gt;&lt;del&gt;MC-10534&lt;/del&gt;&lt;/a&gt; and &lt;a href=&quot;https://bugs.mojang.com/browse/MC-2759&quot; title=&quot;Big Trees become generic small spherical trees.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-2759&quot;&gt;&lt;del&gt;MC-2759&lt;/del&gt;&lt;/a&gt;; doesn&apos;t fix them, but perhaps makes the effects of the feature less noticeable.)&lt;/p&gt;

&lt;p&gt;(Using MCP namings.)&lt;br/&gt;
The &lt;tt&gt;WorldGenBigTree&lt;/tt&gt; has instance variable &lt;tt&gt;heightLimit&lt;/tt&gt;. The same generator instance is used to create many trees during world generation. However, that &lt;tt&gt;heightLimit&lt;/tt&gt; variable is only written to at few occasions; initialization to 0, randomized when it is zero, and when tree height (free space) check deems it needs to be shorter. Thus, the start of world generation can look like this (for tree heights):&lt;br/&gt;
0 -&amp;gt; 10, 10, 10, 10, 10, .. (30 more of 10) .., 7, 7, 7, 7, 7, 10, 10, 10, (10 more of 10), ... (occasional streak of 10 times 11), etc. etc.&lt;/p&gt;

&lt;p&gt;(Edit: ) Note also that the trees are created somewhat &quot;next to next&quot; per location, the same height of trees can be noticed in the world, as many nearby big trees have the same height, then another bunch has another height shared between them, etc.&lt;/p&gt;

&lt;p&gt;&lt;b&gt;Fix?&lt;/b&gt;&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeHeader panelHeader&quot; style=&quot;border-bottom-width: 1px;&quot;&gt;&lt;b&gt;WorldGenBigTree&lt;/b&gt;&lt;/div&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;    &lt;span class=&quot;code-keyword&quot;&gt;public&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; generate(World world, Random random, &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; x, &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; y, &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; z) {
        ...
        &lt;span class=&quot;code-comment&quot;&gt;// FIX? Remove &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt; check.
&lt;/span&gt;        &lt;span class=&quot;code-comment&quot;&gt;//&lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.heightLimit == 0) {
&lt;/span&gt;            &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.heightLimit = 5 + &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.rand.nextInt(&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.heightLimitLimit);
        &lt;span class=&quot;code-comment&quot;&gt;//}
&lt;/span&gt;
        &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (!&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.validTreeLocation()) {
            &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
        }
        ...
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;Tested on 1.4.7 and nice random heights from tree to tree, no sequences of same height observable.&lt;/p&gt;

&lt;p&gt;Since the generated worlds from the same seed (from &lt;a href=&quot;https://bugs.mojang.com/browse/MC-10534&quot; title=&quot;Big oak trees don&amp;#39;t spawn&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-10534&quot;&gt;&lt;del&gt;MC-10534&lt;/del&gt;&lt;/a&gt;) look exactly the same (including the pair of two small &quot;bigtrees&quot;), this affects also all the way to 13w10b, 1.5-pre. (Can not check the code for the latest (only the trees/world), though, but would be quite the miracle if this bug wasn&apos;t there, yet produced same trees.)&lt;/p&gt;</description>
                <environment></environment>
        <key id="25320">MC-11208</key>
            <summary>The big tree generator handles tree height variable incorrectly</summary>
                <type id="1" iconUrl="https://bugs.mojang.com/secure/viewavatar?size=xsmall&amp;avatarId=18903&amp;avatarType=issuetype">Bug</type>
                                    <status id="5" iconUrl="https://bugs.mojang.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ProfMobius">ProfMobius (Thomas Guimbretiere)</assignee>
                                    <reporter username="bugi74">Markku</reporter>
                        <labels>
                            <label>tree-generation</label>
                            <label>world-generation</label>
                    </labels>
                <created>Thu, 7 Mar 2013 12:36:08 +0100</created>
                <updated>Mon, 12 Feb 2018 16:29:19 +0100</updated>
                            <resolved>Mon, 12 Feb 2018 16:29:19 +0100</resolved>
                                    <version>Minecraft 1.4.7</version>
                    <version>Snapshot 13w10b</version>
                    <version>Minecraft 1.5</version>
                    <version>Minecraft 1.6.2</version>
                    <version>Minecraft 1.10.2</version>
                    <version>Minecraft 16w33a</version>
                    <version>Minecraft 16w39c</version>
                    <version>Minecraft 16w40a</version>
                    <version>Minecraft 16w44a</version>
                    <version>Minecraft 1.11</version>
                    <version>Minecraft 17w16b</version>
                                    <fixVersion>Minecraft 18w07a</fixVersion>
                                                        <votes>37</votes>
                                    <watches>13</watches>
                                                                            <comments>
                            <comment id="333611" author="zontargs" created="Thu, 6 Oct 2016 19:00:58 +0200"  >&lt;p&gt;Still an issue in 16w40a.&lt;/p&gt;</comment>
                            <comment id="332983" author="zontargs" created="Mon, 3 Oct 2016 03:08:09 +0200"  >&lt;p&gt;Still an issue in 16w39c.&lt;/p&gt;</comment>
                            <comment id="327780" author="ivan1411" created="Wed, 31 Aug 2016 14:04:43 +0200"  >&lt;p&gt;After some testing I found out that it also changes every time you open any world for the first time after restarting the game and it stays the same for all the others until a new restart. I can&apos;t read the code so I can&apos;t confirm it in any technical way. However, one can recreate it by:&lt;br/&gt;
1) Create a new world that has a forest biome nearby&lt;br/&gt;
2) Wait for the chunks to load&lt;br/&gt;
3) Restart the game &lt;br/&gt;
4) Open the world and go to previously ungenerated chunks &lt;br/&gt;
5) See how large oak tree generation has changed (May not work if the variable randomizes to the same number)&lt;/p&gt;</comment>
                            <comment id="327698" author="torabi" created="Wed, 31 Aug 2016 05:26:37 +0200"  >&lt;p&gt;Confirmed using MCP 9.31 for Minecraft 1.10, and creating new worlds in the current snapshot certainly seems to display the behavior of large numbers of big oak trees with the same height.&lt;/p&gt;</comment>
                            <comment id="295342" author="JIRAUSER71590" created="Fri, 18 Mar 2016 17:11:24 +0100"  >&lt;p&gt;No response for over a year.&lt;/p&gt;</comment>
                            <comment id="206607" author="galaxy_2alex" created="Thu, 30 Oct 2014 19:01:34 +0100"  >&lt;p&gt;Is this still a concern in the &lt;em&gt;current Minecraft version&lt;/em&gt;? If so, please &lt;em&gt;update the affected versions&lt;/em&gt; in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.&lt;/p&gt;

&lt;p&gt;Keep in mind that the &quot;Resolved&quot;-Status on this ticket just means &quot;Answered&quot;, and that we are waiting for further information on whether this issue still exists or not. We will reopen it as soon as the requested information has been deliviered.&lt;/p&gt;</comment>
                            <comment id="149852" author="bugi74" created="Fri, 4 Apr 2014 11:38:45 +0200"  >&lt;p&gt;Due to having &lt;a href=&quot;https://bugs.mojang.com/browse/MC-29844&quot; title=&quot;Big Oak Trees fail to generate in Forest Biomes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-29844&quot;&gt;&lt;del&gt;MC-29844&lt;/del&gt;&lt;/a&gt; around, and no access to code (i.e. MCP for latest versions) to check for sure, it is not possible check the status of this issue and update the affected version for now (except for Mojang coders, of course). That said, I have not seen any big trees by world generation in latest versions (both 1.7.5 and snapshots), so either this or &lt;a href=&quot;https://bugs.mojang.com/browse/MC-29844&quot; title=&quot;Big Oak Trees fail to generate in Forest Biomes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-29844&quot;&gt;&lt;del&gt;MC-29844&lt;/del&gt;&lt;/a&gt; or both are still in effect.&lt;/p&gt;</comment>
                            <comment id="103227" author="bugi74" created="Sat, 14 Sep 2013 11:06:00 +0200"  >&lt;p&gt;The world generation in 1.6.2 still matches the &lt;a href=&quot;https://bugs.mojang.com/browse/MC-10534&quot; title=&quot;Big oak trees don&amp;#39;t spawn&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MC-10534&quot;&gt;&lt;del&gt;MC-10534&lt;/del&gt;&lt;/a&gt; screenshot (which was generated with bugged version), and code seems to look the same (at least the proposed fix part, didn&apos;t check the whole class), so I assume it is still not fixed. Added the version to affects-list.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10102">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="24494">MC-10534</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10103">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="141414">MC-102440</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="50941">MC-29844</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                <customfield id="customfield_10701" key="com.atlassian.jira.plugin.system.customfieldtypes:datetime">
                        <customfieldname>CHK</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 31 Aug 2016 06:12:00 +0200</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Confirmation Status</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10303"><![CDATA[Confirmed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_11700" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_11100" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Linked</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_11600" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0n08n:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>