[MC-9186] Water does not leak through leaves and regular stairs but upside down stairs Created: 04/Feb/13 Updated: 10/Jul/18 Resolved: 10/Jul/18 |
|
| Status: | Resolved |
| Project: | Minecraft: Java Edition |
| Component/s: | None |
| Affects Version/s: | Snapshot 13w05b, Snapshot 13w09a, Snapshot 13w09b, Snapshot 13w09c, Minecraft 1.5, Minecraft 1.5.1, Minecraft 1.5.2, Snapshot 13w18c, Snapshot 13w19a, Minecraft 1.7.4, Minecraft 14w05b, Minecraft 14w06b, Minecraft 14w07a, Minecraft 14w08a, Minecraft 1.7.5, Minecraft 14w11b, Minecraft 1.8, Minecraft 1.8.1-pre3, Minecraft 15w46a, Minecraft 1.9.2, Minecraft 16w15a, Minecraft 16w15b, Minecraft 1.9.3 Pre-Release 2, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 1.10.2, Minecraft 16w43a, Minecraft 1.11.2, Minecraft 17w13b, Minecraft 1.12 Pre-Release 6, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 18w07a, Minecraft 18w11a, Minecraft 18w20c, Minecraft 18w22c, Minecraft 1.13-pre2, Minecraft 1.13-pre5 |
| Fix Version/s: | Minecraft 1.13-pre7 |
| Type: | Bug | ||
| Reporter: | Simons Mith | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 12 |
| Labels: | dripping, leak, leaves, stairs, water | ||
| Environment: |
Mac Os 10.5.8, oldish 3GB iMac |
||
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| CHK: | |||||||||||||||||||||
| Confirmation Status: | Confirmed | ||||||||||||||||||||
| Description |
|
Water (still or flowing) does not drip through leaf blocks, even though rain does. Water also seems not to penetrate certain other blocks that it should. These are all transparent variants as far as I can tell. Stairs - stop leaks, upside down stairs - leak; upper slabs - leak, lower slabs - don't leak; ice - doesn't leak; and even water itself, if you have a free-floating water block, it doesn't so much as dribble. See also |
| Comments |
| Comment by [Mod] Asteraoth [ 10/Jul/18 ] |
|
Fixed in 1.13-pre7 |
| Comment by [Mod] Asteraoth [ 29/Jun/18 ] |
|
Confirmed for 1.13-pre5 |
| Comment by [Mod] Asteraoth [ 16/Jun/18 ] |
|
Confirmed for 1.13-pre2 |
| Comment by [Mod] Asteraoth [ 02/Jun/18 ] |
|
Confirmed for 18w22c |
| Comment by [Mod] Asteraoth [ 19/May/18 ] |
|
Confirmed for 18w20c |
| Comment by [Mod] Asteraoth [ 14/Mar/18 ] |
|
Confirmed for 18w11a |
| Comment by [Mod] Asteraoth [ 15/Feb/18 ] |
|
Confirmed for 18w07a |
| Comment by [Mod] Asteraoth [ 13/Nov/17 ] |
|
Confirmed for 17w45b |
| Comment by [Mod] Asteraoth [ 02/Apr/17 ] |
|
Confirmed for 17w13b |
| Comment by [Mod] Asteraoth [ 22/May/16 ] |
|
Confirmed for 16w20a |
| Comment by [Mod] Asteraoth [ 15/May/16 ] |
|
Confirmed for 1.9.4 |
| Comment by [Mod] Asteraoth [ 02/May/16 ] |
|
Confirm for 1.9.3 pre-2 |
| Comment by [Mod] Asteraoth [ 13/Apr/16 ] |
|
Confirmed for 16w15a and 16w15b |
| Comment by Swekob [ 17/Nov/15 ] |
|
Confirmed for 15w46a |
| Comment by Itouch2 [ 15/Mar/14 ] |
|
Confirmed for 14w10c and 14w11b |
| Comment by Itouch2 [ 01/Mar/14 ] |
|
Still a concern in 1.7.4/5 and 14w08a |
| Comment by Markku [ 18/Mar/13 ] |
|
This issue still in 1.5. |
| Comment by Markku [ 18/Mar/13 ] |
|
For me, on 1.5, both wood and brick stairs produce similar effect. And while the effects is a little bit like "why do they leak?", it is actually a different issue, and probably will be considered a feature. At least I could not see any water effects (well) below the stair blocks (unless they were also horizontally right next to a stairs block). Such drops would have indicated "leaking", which this particular JIRA issue is about. Technically, at least what I saw, was not the dripping (droplets drop down from block's bottom side), but "splashes" (splash up and back down on block's top surface). However, the splashing (and dripping) only consider a single level for the whole block to start from, and since stairs have two levels on the "up" side, it works a little bit better when the effect starts at the half-block level. For the other taller side of stairs, this means the splashes will be inside the block. And that is what at least I could see, the rare splashes that started near the inner surface. It is possible to "fix" that (as the necessary methods to get the proper surface do exist), but it might be a bit inefficient, and it would certainly be worthy of another issue, for Mojang to decide. |
| Comment by Daniel Lunsford [ 18/Mar/13 ] |
|
Attached image |
| Comment by Kumasasa [ 18/Mar/13 ] |
|
Use "More Actions" -> "Attach file" for attaching screenshots. Not "Attach Screenshot" |
| Comment by Daniel Lunsford [ 18/Mar/13 ] |
|
Attachments not cooperating; http://www.drlgraphics.com/images/Minecraft/driperrorexample.png Can't really show the "drip" without video |
| Comment by Markku [ 18/Mar/13 ] |
|
That description is a bit difficult to understand, could you attach a screenshot which shows the setup? |
| Comment by Daniel Lunsford [ 18/Mar/13 ] |
|
I have a leaky roof of brick stairs, rightside-up, dripping from the upper seam (not the lower, apparently). FWIW, it seems similar to the way light "leaks" through the seams on stairs as well. v1.5 Edit: Actually, it might be more accurate to say that it drips from the joins where there is an air-block to either side of it Further Edit: It occurs to me now that I did NOT see this when the roof was wood, only after I switched to brick |
| Comment by Markku [ 02/Mar/13 ] |
|
Fix BlockFluid.randomDisplayTick() ...
if (random.nextInt(10) == 0
//&& world.doesBlockHaveSolidTopSurface(x, y - 1, z)
&& world.getBlockMaterial(x, y - 1, z).blocksMovement()
&& !world.getBlockMaterial(x, y - 2, z).blocksMovement()) {
var21 = (double) ((float) x + random.nextFloat());
var22 = (double) y - 1.05D; // <== MC-1390 ?
var23 = (double) ((float) z + random.nextFloat());
if (this.blockMaterial == Material.water) {
world.spawnParticle("dripWater", var21, var22, var23, 0.0D, 0.0D, 0.0D);
} else {
world.spawnParticle("dripLava", var21, var22, var23, 0.0D, 0.0D, 0.0D);
}
}
Fix tested on 1.4.7, also with fences, iron bars, glass block. Not tested on everything, but if something does not work right, that just means a bit more logic into that if. |
| Comment by Markku [ 02/Mar/13 ] |
|
Affects 13w09c. Related to |
| Comment by Kumasasa [ 04/Feb/13 ] |
|
Confirmed. |