[MC-9] Dropped anvil makes no sound when it breaks Created: 24/Oct/12  Updated: 19/Aug/18  Resolved: 09/Aug/16

Status: Resolved
Project: Minecraft: Java Edition
Component/s: None
Affects Version/s: Minecraft 1.4.1, Minecraft 1.4.4, Minecraft 1.4.7, Snapshot 13w02b, Snapshot 13w03a, Snapshot 13w10b, Minecraft 1.5, Minecraft 1.5.2, Minecraft 1.6.1, Minecraft 1.6.2, Minecraft 1.6.4, Minecraft 13w38c, Minecraft 13w39b, Minecraft 13w41a, Minecraft 13w41b, Minecraft 13w42a, Minecraft 13w42b, Minecraft 13w43a, Minecraft 1.7.1, Minecraft 1.7.2, Minecraft 13w48a, Minecraft 13w48b, Minecraft 13w49a, Minecraft 1.7.3, Minecraft 1.7.4, Minecraft 14w02c, Minecraft 14w03a, Minecraft 14w03b, Minecraft 14w05b, Minecraft 14w06b, Minecraft 14w07a, Minecraft 14w08a, Minecraft 1.7.5, Minecraft 14w10b, Minecraft 14w10c, Minecraft 1.7.9, Minecraft 14w21b, Minecraft 1.7.10, Minecraft 14w33c, Minecraft 14w34a, Minecraft 14w34b, Minecraft 14w34c, Minecraft 14w34d, Minecraft 1.8-pre1, Minecraft 1.8-pre2, Minecraft 1.8-pre3, Minecraft 1.8, Minecraft 1.8.1-pre2, Minecraft 1.8.1-pre3, Minecraft 1.8.1-pre5, Minecraft 1.8.1, Minecraft 1.8.2-pre1, Minecraft 1.8.3, Minecraft 1.8.4, Minecraft 1.8.5, Minecraft 1.8.6, Minecraft 1.8.8, Minecraft 15w31a, Minecraft 15w33a, Minecraft 15w33b, Minecraft 15w41b, Minecraft 15w43a, Minecraft 15w44a, Minecraft 15w45a, Minecraft 15w46a, Minecraft 15w47a, Minecraft 15w47b, Minecraft 15w47c, Minecraft 15w49a, Minecraft 15w49b, Minecraft 15w50a, Minecraft 15w51b, Minecraft 16w02a, Minecraft 16w05b, Minecraft 16w06a, Minecraft 16w07a, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1, Minecraft 1.9.2, Minecraft 16w14a, Minecraft 16w15b, Minecraft 1.9.3 Pre-Release 2, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 16w21a, Minecraft 16w21b, Minecraft 1.10 Pre-Release 1, Minecraft 1.10 Pre-Release 2, Minecraft 1.10, Minecraft 1.10.1, Minecraft 1.10.2
Fix Version/s: Minecraft 16w32a

Type: Bug
Reporter: Mustek Assignee: [Mojang] Agnes Larsson
Resolution: Fixed Votes: 86
Labels: sound
Environment:

Windows 7 x64
Java 1.7u10


Issue Links:
Duplicate
is duplicated by MC-3646 Mute Anvil Resolved
Relates
relates to MC-135868 Anvils broken by falling or overusage... Open
CHK:
Confirmation Status: Confirmed

 Description   

Dropped anvil makes no sound on impact if it breaks

*Desired effect:*
Should make a shattering sound when it meets the ground

What actually happened was...:
No sound at all

Steps to Reproduce:
1. Drop heavily damaged anvil from 14 high


Code analysis by __null in this comment



 Comments   
Comment by Fabian Röling [ 10/Aug/16 ]

Well, the falling sound is still missing.

Comment by user-f2760 (Inactive) [ 10/Aug/16 ]

It's one sound.

I too think a different (new) sound would be better, but that's a feature request.

Comment by Fabian Röling [ 10/Aug/16 ]

Yes, that contains the usage sound. Is it one sound file together? What I meant is that it shouldn't play the sound of the three metallic hits, but instead the one of a falling anvil. It just sounds like a normal anvil breaking after using it.

Comment by user-f2760 (Inactive) [ 10/Aug/16 ]

FaRoGaming if you listen better, you hear it's the sound when it breaks on use.

Comment by Fabian Röling [ 10/Aug/16 ]

It now makes a sound as if it would be used (for combining etc.). But no sound for landing.

Comment by null (Inactive) [ 28/Jun/16 ]

Since marcono1234 hasn't done a code analysis for this bug yet, I guess I'll do it myself. Minecraft 1.10 decompiled with MCP 9.30

The sound is played in net.minecraft.block.BlockAnvil.onEndFalling(World, BlockPos); the issue is that that method is not called if the entity is not set as a block when it lands.

To fix the bug, net.minecraft.block.BlockFalling.onEndFalling(World, BlockPos) could simply be called even if the entity does not set a block when it lands.

net.minecraft.entity.item.EntityFallingBlock.onUpdate()
                        // This part will be executed when the entity lands on the ground.
                        if (!canSetAsBlock) {
                            if (worldObj.canBlockBePlaced(block, blockpos1, true, EnumFacing.UP, (Entity) null, (ItemStack) null)
                                    && !BlockFalling.canFallThrough(worldObj.getBlockState(blockpos1.down()))
                                    && worldObj.setBlockState(blockpos1, fallTile, 3)) {
                                if (block instanceof BlockFalling) {
                                    // This plays the sound, in the case of an anvil.
                                    ((BlockFalling) block).onEndFalling(worldObj, blockpos1);
                                }
                                ...
                            }
                        } else if (block instanceof BlockFalling) {
                            // Added this elseif clause
                            ((BlockFalling) block).onEndFalling(worldObj, blockpos1);
                        }
Comment by tomatitus1 [ 28/Jun/16 ]

Confirmed for 1.10.2

Comment by null (Inactive) [ 22/Jun/16 ]

Confirmed for 1.10.1.

Comment by null (Inactive) [ 08/Jun/16 ]

Confirmed for 1.10.

Comment by null (Inactive) [ 07/Jun/16 ]

Confirmed for 1.10-pre2.

Comment by null (Inactive) [ 03/Jun/16 ]

Confirmed for 1.10-pre1.

Comment by null (Inactive) [ 26/May/16 ]

Confirmed for 16w21b.

Comment by null (Inactive) [ 25/May/16 ]

Confirmed for 16w21a.

Comment by [Mod] Asteraoth [ 22/May/16 ]

Confirmed for 16w20a

Comment by [Mod] Asteraoth [ 15/May/16 ]

Confirmed for 1.9.4

Comment by [Mod] Asteraoth [ 02/May/16 ]

Confirm for 1.9.3 pre-2

Comment by [Mod] Asteraoth [ 14/Apr/16 ]

Confirmed in 16w15b

Comment by QwertyuiopThePie [ 27/Feb/16 ]

Confirmed for 1.9-pre4

Comment by Erik [ 25/Feb/16 ]

Confirmed for 1.9-pre3

Comment by Immaterialise [ 17/Feb/16 ]

Confirmed for 1.9-pre1

Comment by Sealbudsman [ 15/Feb/16 ]

Confirmed 16w07a

Comment by Deaken Barnabe [ 19/Jan/16 ]

confirmed 16w02a

Comment by Roy Sajima [ 18/Dec/15 ]

Confirmed for 15w51a & 15w51b.

Comment by Roy Sajima [ 10/Dec/15 ]

Comfirmed for 15w50a

Comment by Roy Sajima [ 08/Dec/15 ]

confirmed for 15w49b

Comment by Commander Sealand [ 02/Dec/15 ]

Confirmed for 15w49a

Comment by EP1CxEMAN08 [ 23/Nov/15 ]

Confirmed for 15w47c

Comment by EP1CxEMAN08 [ 23/Nov/15 ]

Does it work for 15w47c?

Comment by Commander Sealand [ 19/Nov/15 ]

Confirmed for 15w47b

Comment by Commander Sealand [ 18/Nov/15 ]

Confirmed for 15w47a

Comment by 19Spleen [ 12/Nov/15 ]

Confirmed for 15w46a

Comment by 19Spleen [ 05/Nov/15 ]

Confirmed for 15w45a

Comment by Swekob [ 29/Oct/15 ]

Confirmed for 15w44a.

Comment by [Mod] Neko [ 11/Oct/15 ]

Confirmed for 15w41a

Comment by husky2490 [ 29/Jul/15 ]

Confirmed for Snapshot 15w31a

Comment by Mikkel Hansen [ 26/May/15 ]

Confirmed for 1.8.6

Comment by husky2490 [ 18/May/15 ]

Confirmed for 1.8.4

Comment by Mikkel Hansen [ 25/Feb/15 ]

Remember to add 1.8.3 as an affected version. Hopefully this is fixed before the 1.9 release.

Comment by Dlawso the Really Lucky Rabbit [ 20/Dec/14 ]

Still in 1.8.2-pre1

Comment by [Mod] Sonicwave [ 21/Nov/14 ]

Unfortunately not, only the reporter or mods can update an issue.

Comment by George Gates [ 20/Nov/14 ]

Still an issue in 1.8.1-pre5.

(Also I'm not sure if normal users /can/ upgrade the version list themselves on somebody else's submitted bug report.)

Comment by Lucas Ignacio Morrison Osorio [ 08/Nov/14 ]

Is this still a concern in Minecraft 1.8.1 pre-release 4? If so, be sure to update the "Affects Versions"

Comment by George Gates [ 18/Oct/14 ]

Confirmed in 1.8.1-pre2.

Comment by [Mod] Sonicwave [ 18/Sep/14 ]

Confirmed in 1.8.

Comment by [Mod] Sonicwave [ 29/Aug/14 ]

Confirmed in 1.8-pre3.

Comment by [Mod] Sonicwave [ 26/Aug/14 ]

Confirmed in 1.8-pre2.

Comment by Dlawso the Really Lucky Rabbit [ 25/Jul/14 ]

It appears that this bug (MC-61794) is now preventing this from occuring in 30c.

Comment by Marcus McDermand [ 09/Mar/14 ]

Confirmed in 14w10c

Comment by Itouch2 [ 23/Feb/14 ]

Confirmed for 08a

Comment by Chloe Idun Anderson [ 04/Mar/13 ]

Can we get a confirmation of whether this happens in 13w10a and an update to the affected versions?

Comment by Tails [ 20/Dec/12 ]

Yes.

Comment by Anon Ymus [ 20/Dec/12 ]

So it's just a planned fix?

Comment by Tails [ 20/Dec/12 ]

It's not, it's gonna be.

Comment by Anon Ymus [ 20/Dec/12 ]

How is this fixed when there is no assignee?

Comment by Mortvert (Mort Imert) [ 29/Nov/12 ]

Can you replicate this issue in latest version of the minecraft? If so, can you update the ticket?

Comment by Michael Irvine [ 16/Nov/12 ]

Hey I have an attachment to this if you drop an anvil on a half slab, it will pop out of the ground and possibly turn into a slightly damaged anvil, then slightly to very. However, if you drop a nery damaged anvil high enough so that it will become damaged,it stays as an entity. Yes, I know it's an entity because it lays on the skab as if the slab were a solid block.

Comment by TnT (Trinitro Toluene) [ 10/Nov/12 ]

Is this still a concern on Minecraft 1.4.4 Pre-Release? If so, please update the version affected.

This ticket is a grey area whether this is intended, or a bug, however, for now please confirm if its still an issue.

Comment by [Mod] Ezekiel (ezfe) [ 24/Oct/12 ]

Not technically a bug, more like a feature request.

Comment by Cloudy (Aaron Mills) [ 24/Oct/12 ]

Not sure if is actually a bug or just something that doesn't happen - however can confirm that I get the behaviour in the description.

Generated at Sun Jan 12 11:49:29 UTC 2025 using Jira 9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13.