[MC-7882] Cloud corners not connected Created: 19/Jan/13 Updated: 16/Dec/19 Resolved: 16/Dec/19 |
|
| Status: | Resolved |
| Project: | Minecraft: Java Edition |
| Component/s: | None |
| Affects Version/s: | Snapshot 13w03a, Snapshot 13w09a, Snapshot 13w09b, Snapshot 13w09c, Minecraft 1.5, Minecraft 1.5.1, Minecraft 1.5.2, Minecraft 1.6.2, Minecraft 13w36a, Minecraft 14w04b, Minecraft 14w06b, Minecraft 1.7.9, Minecraft 14w17a, Minecraft 14w18a, Minecraft 1.8, Minecraft 1.8.1-pre4, Minecraft 1.8.8, Minecraft 15w31c, Minecraft 15w44a, Minecraft 1.10.2, Minecraft 16w41a, Minecraft 16w42a, Minecraft 16w43a, Minecraft 1.11.2, Minecraft 17w14a, Minecraft 17w15a, Minecraft 1.12.2, Minecraft 17w50a, Minecraft 18w16a, Minecraft 18w20a, Minecraft 18w22a, Minecraft 1.13, Minecraft 1.13.2, Minecraft 18w43b, Minecraft 18w43c, Minecraft 18w44a, Minecraft 18w45a, 1.14.4, 1.15 Pre-release 1 |
| Fix Version/s: | Minecraft 1.8, Minecraft 18w10d |
| Type: | Bug | ||
| Reporter: | idontwantthemtoknow | Assignee: | Unassigned |
| Resolution: | Cannot Reproduce | Votes: | 23 |
| Labels: | None | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| CHK: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Confirmation Status: | Confirmed | ||||||||||||||||||||||||||||||||||||||||||||||||
| Category: |
Rendering
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
When playing Minecraft, I noticed that clouds had the sides off. I have checked to see if it was the top and bottom that were out, but the top and bottom lined up to the edge of the dirt, right down to the pixel. The South-East edge are a tiny bit in, while the North-West are a tiny bit out. Can this be fixed? |
| Comments |
| Comment by Fabian Röling [ 16/Dec/19 ] |
| Comment by [Mod] violine1101 [ 16/Dec/19 ] |
|
This ticket does no longer describe the issue. We need a new ticket to no longer have the old, now incorrect, information in the ticket. Plus, it's way less effort. This ticket won't be reopened. |
| Comment by jonathan2520 [ 16/Dec/19 ] |
|
It seems silly to make a new report just because the manifestation has changed slightly. The corners are in fact not connected. It was never specifically about gaps, even though that can still happen due to rounding in the rasterizer (which you can prevent by supplying it with robust geometry) and those lines might as well be gaps from a distance. |
| Comment by _zombiehunter [ 16/Dec/19 ] |
|
FaRo1 Actually, your screenshots show exactly what Roq12 described, the cloud faces slightly overlap where they connect. There's no more open gaps, so this ticket is no longer relevant as of 1.15. If you think that it still doesn't look correct, feel free to create a new ticket, if there isn't one out there already (search before making a new one!). |
| Comment by Fabian Röling [ 16/Dec/19 ] |
|
I added some screenshots from 1.15.1-pre1, please reopen. Maybe the exact look has changed, but it's still not correct. |
| Comment by Thommy Siverman [ 16/Dec/19 ] |
|
Even though there is a little bit of overlap where two sides of a cloud connect, it looks nothing like the issue described in this ticket. Closing as Cannot Reproduce on 1.15 .1 pre-release 1. |
| Comment by Greg Milson [ 29/May/18 ] |
|
Affects 18w22a |
| Comment by Greg Milson [ 16/May/18 ] |
|
Still an Issue in 18w20a |
| Comment by Greg Milson [ 03/May/18 ] |
|
Still an issue in 18w16a, the cloud corners still aren't connected, I added a screenshot showing it. |
| Comment by fasdasdfasd [ 10/Nov/16 ] |
|
------ <Sky |
| Comment by jonathan2520 [ 10/Aug/16 ] |
|
I tried it on the Intel Iris Pro 5200 in my laptop. Of course it doesn't fix the garbage in, garbage out of bad geometry. What it does fix relative to the GeForce 750M is the frayed edges. Interesting that NVIDIA is worse in this regard. It's generally best for Minecraft, at least in part because it's all Mojang seems to be using. I booted in Windows to verify the GeForce behaves the same there, which it does. Then again, it only shows when you get close to the plane of a cloud. It isn't unconditionally super-obvious. That might be why Mojang let it slip. |
| Comment by user-f2760 (Inactive) [ 05/Aug/16 ] |
|
Relates, not a duplicate by far, this issue is on way more easily noticable then MC-1794 is. |
| Comment by null (Inactive) [ 05/Aug/16 ] |
|
Relates to / is a duplicate of MC-1794 |
| Comment by jonathan2520 [ 01/Aug/16 ] |
|
I had another look at it in 1.10.2. It looks like all the quads are translated toward the corner of the box with the smallest XYZ coordinates. So a single cloud has its own quads intersecting each other. All adjacent coplanar quads line up, however. Note that the eastern quad of one box is positioned slightly too far west so there are two distinct quads between two connected boxes. This goes for the other dimensions, too. If you get in that space in just the right way you can make the back face of a cloud disappear. There's some cracking because the mesh is full of T-intersections. The frayed edges are also still there if you get close. It's quite visible from a distance, probably because of the cracking or perhaps the depth buffer. All quads are always drawn, even inside clouds and in clear sky. It results in this kind of intersection: /\ two faces facing the camera,
camera ----- / \ <---- overlapping from its perspective
/ \ and meeting at a vertex/edge
That causes problems with the depth buffer, when fragments from different faces are quantized to the same depth value (which can easily happen because fragments can get arbitrarily close to the vertices and edges where the faces connect). It's just like the speckles on a snow layer grid. I think the draw order may have been tweaked at some point to disambiguate in favor of the face that happens to be correct most of the time. Nevertheless, because the mesh is full of cracks, you can still see funny lines between cloud boxes from a distance, even from the bottom where where things would line up given infinite precision. The frayed edges depend on where exactly you are in the cloud grid. Even repetitions of the same bit of cloud texture are different. Every repetition (12 blocks per texel * 256 texels = 3072 blocks) in the positive direction gets progressively worse, until it instantly improves again every 8th repetition (24576 blocks). In fact, as you cross the z≡-3.96 (mod 24576) plane, there's a very jarring transition between the best and the worst. x is less predictable because the clouds are constantly moving on that axis. Anyway, theoretical precision of 32-bit floating point drops down to about 683 units per block. You might expect problems if you got close, but not problems that are that bad. What really pushes it into crazy territory is the effect of perspective. The closer I get to the plane while looking at the horizon, the worse it gets. This applies even to parts that are far away horizontally and so don't get much closer at all as I move vertically. This is exactly the kind of thing that's really hard on rasterizers, when a polygon's depth ranges from very close to very far, all on screen. The line extends across multiple polygons including easier ones, however. I think my GPU sets up interpolation so that it works across the screen without considering the area covered by the polygon. That makes sense given NVIDIA's heritage of clipless rasterizers. Not sure what they do nowadays but vertices do snap to a 256th of a pixel as apparently mandated by D3D10. Not something you'd normally expect a clipless rasterizer to do. Just for completeness, the flat "fast" clouds act similarly but to a much lesser extent. The texels are a bit smaller at 8 blocks which already helps. In addition, the texture coordinates are reset for every repetition. That makes it 12 times as good. Not great, but it's okay for what it is. "Fancy" clouds could easily have comparable precision without overhauling them in any way. I got curious enough to check the decompiled source of MCP. The top and bottom faces are drawn in bunches of 8x8 texels per quad. Each of the other four kinds of face is then drawn as 8 8-wide strips in the sandwich. It's no surprise there are cracks, huh? Looking back on when I checked the polygon depth thing, what appeared to be multiple polygons is really one. Indeed, when I find the actual edge of the polygon, the screwy line doesn't extend to the next one. So the GPU really does take the covered area into account. Another thing cleared up. Edit: To reply more directly, this looks very much like the original report and screenshots. Only the March 2013 screenshot is clearly different. Not that I care about a word-for-word match, but there is one. |
| Comment by Fabian Röling [ 31/Jul/16 ] |
|
I see a slight overlap on some clouds, like the comment before this one stated, but only the top part overlaps the sides and I don't see unconnected corners. Can someone confirm that part for 1.10.2? |
| Comment by jonathan2520 [ 09/Nov/14 ] |
|
In addition to the corners being slightly offset, the planes tend to have frayed edges, sometimes projecting well outside the actual cloud. No change that I know of; I'm just documenting how it's been for me for a long time. I just noticed my profile was still using Java 8u20. I verified that 7u72 and 8u25 exhibit the same issue. This is on OS X 10.9.5, with some further details in the screenshots (F3). |
| Comment by [Mod] Neko [ 08/Nov/14 ] |
|
Cannot Reproduce in 1.8.1-pre4 |
| Comment by [Mod] Sonicwave [ 08/Nov/14 ] |
|
Regressed in 1.8.1-pre4 ( |
| Comment by Galaxy_2Alex [ 25/Oct/14 ] |
|
Cannot Reproduce in 1.8, assuming it's Fixed. |
| Comment by Itouch2 [ 01/May/14 ] |
|
Confirmed for 1.7.5, 1.7.9 and 14w17/8a |
| Comment by Tintti214 [ 27/Jan/14 ] |
|
Confirmed for 14w04b EDIT: Was able to reproduce in 14w06b |
| Comment by Fjodor Dostojewski [ 24/Mar/13 ] |
|
Confirmed for 1.5.1 |
| Comment by idontwantthemtoknow [ 15/Mar/13 ] |
|
I haven't checked the latest snapshot to see if it is still affected, but I'm sure it is. It doesn't say it's fixed in it. |
| Comment by Jesper the End [ 03/Mar/13 ] |
|
confirmed (I made duplicate accidentally, I searched for 'cloud' but I didn't find this one) |
| Comment by Kumasasa [ 25/Feb/13 ] |
|
Confirmed. |
| Comment by idontwantthemtoknow [ 23/Jan/13 ] |
|
These screenshots took a long time to get right... |
| Comment by idontwantthemtoknow [ 20/Jan/13 ] |
|
No. That is different. I am talking about clouds having their sides being too far in or out. |
| Comment by Kumasasa [ 19/Jan/13 ] |
|
|