[MC-7424] Fall damage death messages don't show block player fall from correctly (ladders, vines, water) Created: 13/Jan/13 Updated: 09/Jul/22 Resolved: 26/Feb/20 |
|
| Status: | Resolved |
| Project: | Minecraft: Java Edition |
| Component/s: | None |
| Affects Version/s: | Snapshot 13w02b, Minecraft 1.5, Snapshot 13w11a, Minecraft 1.6.2, Minecraft 1.7.4, Minecraft 14w03b, Minecraft 1.8, Minecraft 1.8.1-pre3, Minecraft 1.8.3, Minecraft 1.8.8, Minecraft 15w47b, Minecraft 1.10, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 16w35a, Minecraft 1.11.2, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 17w43a, Minecraft 17w43b, Minecraft 18w03b, Minecraft 1.13-pre3, Minecraft 1.13-pre6, Minecraft 1.13-pre7, Minecraft 1.13, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 19w03b, Minecraft 19w03c, Minecraft 1.14 Pre-Release 2, Minecraft 1.14 Pre-Release 3, Minecraft 1.14 Pre-Release 4, 1.15.1 |
| Fix Version/s: | 20w09a |
| Type: | Bug | ||
| Reporter: | [Mod] NeunEinser | Assignee: | [Mojang] Felix Jones |
| Resolution: | Fixed | Votes: | 22 |
| Labels: | death, fall-damage, ladders, messages, vines, water | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| CHK: | |||||||||||||||||||||||||||||||||||||||||
| Confirmation Status: | Confirmed | ||||||||||||||||||||||||||||||||||||||||
| Game Mode: | Survival | ||||||||||||||||||||||||||||||||||||||||
| Category: |
(Unassigned)
|
||||||||||||||||||||||||||||||||||||||||
| Description |
The bugDeath messages, such as:
don't show instead it is just <player> fell from a high place How to reproduce
See also this reddit post: http://www.reddit.com/r/Minecraft/comments/2wpmer/help_me_die/ Code analysisCode analysis by Schortan can be found in this comment |
| Comments |
| Comment by [Mod] ManosSef [ 18/Mar/20 ] |
|
FaRo1 In this video (https://www.youtube.com/watch?v=YbuWmY0p6a4) which you commented above, Etho played in 13w04a. In 13w02a-13w04a, falling death messages worked in an interesting way: There were two types of messages, " [player] 'first' " and " [player] 'first' and 'last' ". <first> could be:
<last> could be:
I've done the math. There were 352 different death messages. |
| Comment by Fabian Röling [ 05/Jul/19 ] |
|
This video was uploaded on 2019-08-19, so it was recorded about 70 days after the release of 1.6.2 and before the next snapshot (13w36a), so Etho was very likely playing in 1.6.2: https://youtu.be/Etf9CJxvKeM?t=1296 He got the death message "<player> fell off a ladder", even though that is in the version list of this report. Kumasa, do you still remember how you tested it back then? It was apparently wrong. |
| Comment by [Mod] violine1101 [ 13/Jun/19 ] |
|
This ticket only covers fall damage caused by falling off blocks, it does not cover being hit by mobs (or players) and then dying of fall damage. There's probably another ticket about those cases. |
| Comment by Fabian Röling [ 12/Jun/19 ] |
|
According to an unofficial, fan-made Mindcrack wiki, the server always used the latest snapshot since the end of 2012, so this video should have been recorded in 13w10b: https://youtu.be/L8HHrijSwRg?t=508 It shows one of these very descriptive death messages, even though an earlier version is listed here. I just tested it in 1.6.2 and got "was doomed to fall by zombie". In 1.14.2-pre3 I get "fell from a high place". In 1.4.7 it's also "fell from a high place". I didn't try old snapshots, because they aren't in the launcher, so it's complicated to get them. Something is very strange about the versions marked in this report. |
| Comment by Fabian Röling [ 05/Jun/19 ] |
|
This video was uploaded on the 1st of February 2013 and recorded shortly before, on a server that was either on the latest version or even a pretty recent snapshot at that point: https://www.youtube.com/watch?v=YbuWmY0p6a4 |
| Comment by Makzevu [ 17/Apr/19 ] |
|
Confirmed for 1.14 Pre-Release 4. |
| Comment by Nixinova [ 26/Jan/19 ] |
|
"<player> was doomed to fall by / walked into a cactus/drowned whilst fighting <mob>" only seems to appear when the time between the mob damage and death is very, very short, like if a zombie hits you into a cactus while you are on 2.5 hearts only then will that message display |
| Comment by Insane96MCP [ 25/Aug/18 ] |
|
Can confirm for 1.13.1 ... Afaik there were messages like "<player> was doomed to fall by <mob>" |
| Comment by Makzevu [ 19/Jul/18 ] |
|
Can anyone confirm for 1.13? |
| Comment by [Mod] Michael Wobst [ 26/Oct/17 ] |
|
Schortan ticket is yours now. |
| Comment by [Mod] NeunEinser [ 26/Oct/17 ] |
|
Can confirm for 17w43a/b |
| Comment by Marcono1234 [ 21/Jan/17 ] |
|
Removed not existing death messages from description |
| Comment by [Mod] NeunEinser [ 21/Jan/17 ] |
|
Can confirm for 1.11.2 |
| Comment by [Mod] NeunEinser [ 10/Aug/16 ] |
|
Can confirm for 16w32a. |
| Comment by [Mod] NeunEinser [ 28/Jul/16 ] |
|
Also can confirm for 1.10.2 |
| Comment by [Mod] NeunEinser [ 28/Jul/16 ] |
|
Please link this post in the description. Why this happens How to fix Changes/additions I made to net.minecraft.util.CombatTracker net.minecraft.util.CombatTracker /* * keeps track of the block that the entity was climbing on. */ private Block fallSuffixBlock; public void calculateFallSuffix() { this.resetFallSuffix(); if (this.fallSuffixBlock != null) { if (this.fallSuffixBlock == Blocks.LADDER) { this.fallSuffix = "ladder"; } else if (this.fallSuffixBlock == Blocks.VINE) { this.fallSuffix = "vines"; } else if (this.fallSuffixBlock == Blocks.WATER || this.fallSuffixBlock == Blocks.FLOWING_WATER) { this.fallSuffix = "water"; } this.setFallSuffixBlock(null); } } public void setFallSuffixBlock(Block blockIn) { this.fallSuffixBlock = blockIn; } Then I made a simple condition in net.minecraft.entity.EntityLivingBase.onUpdate() to keep it updated. net.minecraft.entity.EntityLivingBase.onUpdate() //... added at line 2237 if (this.isOnLadder()) //Also true if player is on vines, therefore need to check for actual Block. { this.getCombatTracker().setFallSuffixBlock(this.worldObj.getBlockState(new BlockPos(this.posX, this.getEntityBoundingBox().minY, this.posZ)).getBlock()); } else if (this.isInWater()) { this.getCombatTracker().setFallSuffixBlock(Blocks.WATER); } //reset fallSuffixBlock if entity is on solid ground again. else if (this.onGround) { this.getCombatTracker().setFallSuffixBlock(null); } //... |
| Comment by SunCat [ 15/Jun/16 ] |
|
Still in 1.10 |
| Comment by Étienne B. [ 19/Nov/15 ] |
|
Confirmed for 1.8.8 |
| Comment by Kumasasa [ 01/Nov/14 ] |
|
Updated, thanks. |
| Comment by Aaron Opell [ 01/Nov/14 ] |
|
Yes, it still seems to be an issue in the current Minecraft version. I have not seen death messages for "<player> fell off a ladder" and "<player> fell off some vines" as well as some others do not appear to display in the game. These are the death messages in the EN_US.lang file in the 1.8.jar: death.fell.accident.ladder=%1$s fell off a ladder |
| Comment by Galaxy_2Alex [ 30/Oct/14 ] |
|
Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue. Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. We will reopen it as soon as the requested information has been deliviered. |
| Comment by [Mod] Torabi [ 22/Nov/13 ] |
|
Probably a result of the changes Jeb had to make to fix |
| Comment by [Mojang] Nathan Adams [ 17/Jan/13 ] |
|
I don't recall confirming this is a bug. The "finished off" text is only for when you fell previously, "x fell from a high place and was finished off by y" and not just plain old "x was finished off by y", so that part is working as intended. As for /kill on vines/ladders, that's just a special case of how /kill works. Won't fix for this snapshot, we'll see for next. |
| Comment by Aaron Opell [ 14/Jan/13 ] |
|
edited the post |
| Comment by [Crispy] PokeCanada [ 13/Jan/13 ] |
|
Sorry. Worded that wrong. Don't close this ticket. |
| Comment by Kumasasa [ 13/Jan/13 ] |
|
Do we erase tickets ? |
| Comment by [Crispy] PokeCanada [ 13/Jan/13 ] |
|
Dinnerbone has confirmed that this is a bug. Note to Mods: Don't erase this until fixed. |