| Type: | Bug | ||
| Reporter: | Grant Cafasso | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 84 |
| Labels: | FOV, fishing-line, fishing_rod | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| CHK: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Confirmation Status: | Confirmed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Category: |
Camera, Items
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Mojang Priority: | Low | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Area: | Platform | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
This is especially seen when the fov is high but it is true any time the fov is changed: running, flying, potion effects. To see for yourself just cast a line in your favorite lake and run. I am mostly certain that this has not been addressed before; all other fishing rod problems were much more different than this. |
| Comments |
| Comment by Mac Rat [ 08/Jun/23 ] |
|
Confirmed in 1.20 |
| Comment by user33 [ 21/Oct/22 ] |
|
Can confirm in 22w42a |
| Comment by [Mod] Avoma [ 14/Sep/22 ] |
|
Can confirm in 1.19.2. |
| Comment by [Mod] Avoma [ 24/Jun/22 ] |
|
Can confirm in 1.19. |
| Comment by [Mod] Avoma [ 02/Mar/22 ] |
|
Can confirm in 1.18.2. |
| Comment by [Mod] ampolive [ 17/Jul/21 ] |
|
Oh, I see. So this bug is still present, it is just fixed for the FOV slider. |
| Comment by [Mod] Pokechu22 [ 17/Jul/21 ] |
|
See this comment for more info; it ignores things that change the FOV modifier, but does look at the FOV option value. Judging only from the duplicates, there was also once an issue where it ignored the FOV option value, but I don't know when/if that changed (and I don't want to separate out that behavior into a new issue because I'm not 100% sure it did change). The sneaking animation is its own issue (MC-148088). I think the aspect ratio problem should also be created as a separate issue (that should be linked to this one). |
| Comment by Fabian Röling [ 17/Jul/21 ] |
|
Examples of what is still causes this in 1.17.1:
|
| Comment by CheesyTheArtist [ 17/Jul/21 ] |
|
This issue seems to be fixed in vanilla 1.17.1, no idea why its tagged as affected in 1.17.1compressed grrrr.mp4 |
| Comment by Bayer Florian [ 27/Jun/21 ] |
|
it's also broken when using a different aspect ratio than 16:9 |
| Comment by PiCO109 [ 14/Jun/21 ] |
| Comment by [Mod] Pokechu22 [ 24/May/21 ] |
|
Code analysis (based on 1.16.4, but the same idea should apply to more recent snapshots): The logic for determining where the hook should be looks like this: if ((this.renderManager.options == null || this.renderManager.options.thirdPersonView <= 0) && playerentity == Minecraft.getInstance().player) { double fov = this.renderManager.options.fov; // ... compute hand position for first person ... } else { // ... compute hand position for third person ... } However, it should look something like this: if (this.renderManager.options != null && this.renderManager.options.thirdPersonView <= 0 && playerentity == Minecraft.getInstance().player) { double fov = this.renderManager.options.fov * playerentity.getFovModifier(); // ... render first person ... } else { // ... render third person ... } Note that this also fixes a null check; if this.renderManager.options is null, then accessing this.renderManager.options.fov won't work. (I don't know if renderManager.options will ever be null though). It also isn't entirely accurate to use playerentity.getFovModifier either, as that doesn't handle the gradual transitions that are applied to the hand FOV in GameRenderer; there is a function there that computes the appropriate FOV that would be better to use. |
| Comment by [Helper] Jack McKalling [ 17/Mar/21 ] |
|
Blocked from testing in 21w11a, by |
| Comment by [Mod] Avoma [ 04/Feb/21 ] |
|
Can confirm in 21w05b. |
| Comment by ProPork [ 02/May/20 ] |
|
Also just checked some additional numbers. The fishing line model is disconnected at FOV's 46 and higher (although the ones from 46-50 are barely noticeable but still there). |
| Comment by ProPork [ 02/May/20 ] |
|
Affects 20w18a |
| Comment by christofin [ 13/Feb/20 ] |
|
There you go - takes 30 seconds to switch to a completely vanilla profile and see that this bug is not an OptiFine bug. Screenshot uploaded.
This has been a problem in the game for 7 going on 8 years now. It's not an OptiFine issue. |
| Comment by Fabian Röling [ 13/Feb/20 ] |
|
Those screenshots are not made in Vanilla Minecraft. I suspect it's OptiFine or similar. Please only test bugs and attach screenshots from Vanilla Minecraft. |
| Comment by christofin [ 12/Feb/20 ] |
|
Attached some screenshots. Line becomes detached at any FOV higher than default, gets worse the higher the FOV. Happens regardless of aspect ratio. At high resolutions I've also noticed that the line completely disappears. Please, Mojang... please look at this very annoying bug! #MakeFishingGreatAgain |
| Comment by Jfarf_Gl [ 02/Feb/20 ] |
|
I would love it this were to be assigned and looked at. It's such an immersion breaking bug for something that pretty much everyone on the Java edition does - changes FOV. |
| Comment by TheBoy358 [ 08/Nov/19 ] |
|
Confirmed in 19w45b. |
| Comment by Wild Katz [ 19/Jul/19 ] |
|
1.14.4 Fishing line doesn't connect to the fishing rod. The gap is kinda smaller right now, but still not correctly connected. |
| Comment by Wild Katz [ 05/Jun/19 ] |
|
Confirmed for 1.14.3 pre-1
Fix this already, it bugs my OCD xD |
| Comment by Jfarf_Gl [ 22/May/19 ] |
| Comment by Jfarf_Gl [ 22/May/19 ] |
|
Confirmed for 1.14.2 pre-3. In first person, the fishing rod's line doesn't fully connect with the rod itself. This is not just an issue with my client, other colleagues have reported the same bug. This happens regardless of resource packs being installed or not. The rod's line does fully connect in third person. See the attached screenshots. |
| Comment by [Helper] Jack McKalling [ 13/May/19 ] |
|
Confirmed for 1.14.1 |
| Comment by [Helper] Jack McKalling [ 09/May/19 ] |
|
Confirmed for 1.14.1 pre-2 |
| Comment by [Helper] Jack McKalling [ 07/May/19 ] |
|
Confirmed for 1.14.1 pre-1 |
| Comment by [Helper] Jack McKalling [ 23/Apr/19 ] |
|
Confirmed for 1.14 |
| Comment by [Helper] Jack McKalling [ 18/Apr/19 ] |
|
Confirmed for 1.14 pre-5 |
| Comment by [Helper] Jack McKalling [ 17/Apr/19 ] |
|
Confirmed for 1.14 pre-4 |
| Comment by [Helper] Jack McKalling [ 16/Apr/19 ] |
|
Confirmed for 1.14 pre-3 |
| Comment by [Mod] violine1101 [ 13/Apr/19 ] |
|
As of 1.14-pre2, the fishing rod seems to only connect properly with FOV set to 30. |
| Comment by [Helper] Jack McKalling [ 10/Apr/19 ] |
|
Confirmed for 1.14 pre-1 |
| Comment by [Helper] Jack McKalling [ 08/Apr/19 ] |
|
Confirmed for 19w14b |
| Comment by [Helper] Jack McKalling [ 03/Apr/19 ] |
|
Confirmed for 19w14a |
| Comment by [Helper] Jack McKalling [ 29/Mar/19 ] |
|
Confirmed for 19w13b |
| Comment by [Helper] Jack McKalling [ 27/Mar/19 ] |
|
Confirmed for 19w13a |
| Comment by [Helper] Jack McKalling [ 21/Mar/19 ] |
|
Confirmed for 19w12b |
| Comment by [Helper] Jack McKalling [ 20/Mar/19 ] |
|
Confirmed for 19w12a |
| Comment by [Helper] Jack McKalling [ 14/Mar/19 ] |
|
Confirmed for 19w11b |
| Comment by [Helper] Jack McKalling [ 13/Mar/19 ] |
|
Confirmed for 19w11a |
| Comment by [Helper] Jack McKalling [ 28/Feb/19 ] |
|
Confirmed for 19w09a |
| Comment by [Helper] Jack McKalling [ 13/Feb/19 ] |
|
Confirmed for 19w07a |
| Comment by [Helper] Jack McKalling [ 06/Feb/19 ] |
|
Confirmed for 19w06a |
| Comment by [Helper] Jack McKalling [ 30/Jan/19 ] |
|
Confirmed for 19w04b and 19w05a |
| Comment by [Helper] Jack McKalling [ 24/Jan/19 ] |
|
Comfirmed for 19w04a |
| Comment by [Helper] Jack McKalling [ 19/Jan/19 ] |
|
Confirmed for 19w03c |
| Comment by [Helper] Jack McKalling [ 17/Jan/19 ] |
|
Confirmed for 19w03b |
| Comment by [Helper] Jack McKalling [ 16/Jan/19 ] |
|
Confirmed for 19w03a |
| Comment by [Helper] Jack McKalling [ 09/Jan/19 ] |
|
Confirmed for 19w02a |
| Comment by [Helper] Jack McKalling [ 12/Dec/18 ] |
|
Confirmed for 18w50a |
| Comment by [Helper] Jack McKalling [ 05/Dec/18 ] |
|
Confirmed for 18w49a |
| Comment by [Helper] Jack McKalling [ 30/Nov/18 ] |
|
Confirmed for 18w48b |
| Comment by [Helper] Jack McKalling [ 29/Nov/18 ] |
|
Confirmed for 18w48a |
| Comment by Selebrator [ 29/Oct/17 ] |
|
Confirmed for 17w43b |
| Comment by user33 [ 27/Apr/17 ] |
|
Confirmed for 17w17a |
| Comment by [Mod] Neko [ 27/Oct/16 ] |
|
Not fixed in 16w43a. |
| Comment by Vytenis Narušis [ 15/Aug/14 ] |
|
Not fixed in 14w33c |
| Comment by Sealbudsman [ 15/Aug/14 ] |
|
Is this fixed in 33b, with the other fishing rod fixes? |
| Comment by Andrew McCluskey [ 20/Jul/14 ] |
|
Confirmed for 14w29a and b. |
| Comment by Itouch2 [ 22/Jun/14 ] |
|
Confirmed for 14w25b. |
| Comment by Itouch2 [ 24/Apr/14 ] |
|
Confirmed for 14w17a |
| Comment by Itouch2 [ 17/Mar/14 ] |
|
Confirmed for 1.7.5 and 14w11b |
| Comment by Sand Lantern [ 27/Oct/13 ] |
|
This bug is still present in release 1.7.2 |
| Comment by Grant Cafasso [ 18/Mar/13 ] |
|
Why yes it is. |
| Comment by Tails [ 17/Mar/13 ] |
|
Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. |
| Comment by Vytenis Narušis [ 26/Jan/13 ] |
|
Still a problem in 13w04a |
| Comment by Pixelgraph [ 08/Jan/13 ] |
|
Confirmed and a very annoying bug. |