[MC-2527] Save is not really complete when /save-all says "Save complete." Created: 08/Nov/12  Updated: 18/Aug/13  Resolved: 18/Aug/13

Status: Resolved
Project: Minecraft: Java Edition
Component/s: None
Affects Version/s: Minecraft 1.4.2, Minecraft 1.5
Fix Version/s: Minecraft 1.6.2

Type: Bug
Reporter: Thue Assignee: Unassigned
Resolution: Fixed Votes: 2
Labels: None
Environment:

Linux


Confirmation Status: Unconfirmed

 Description   

I have a Minecraft server control script called rfwadmin ( https://github.com/Thue/rfwadmin ). That script uses the save-all command for saving. On minecraft_base.sh line 518 ( https://github.com/Thue/rfwadmin/blob/master/fsroot/var/lib/minecraft/minecraft_base.sh#L518 ), I send the /save-all command, and wait for the line "save complete" to appear in the log. Right after I see "save complete", I do a filesystem copy "cp -r" of the presumably saved files.

But the files are not always saved in the copied version!

One way to reproduce in vanilla is to fly over the terrain placing blocks, touching as many chunks as possible quickly. I think that the more chunks you touch, the higher chance that not everything is saved.

While I can sometimes reproduce the issue in vanilla, it is easier to reproduce using craftbukkit and worldedit. Do a "//replacenear 100 bedrock diamond", and you can be sure not all chunks are saved if you do a save-all+"cp -r" right afterwards.



 Comments   
Comment by Thue [ 17/Aug/13 ]

On a related note: I will have to leave in the 30 second sleep to to to work around this bug, since I don't have a good way to know which version a given minecraft binary is... If minecraft_server.jar supported a --version argument it would be very handy.

Comment by Thue [ 17/Aug/13 ]

The bug seems to no longer be present in 1.6.2, neither in vanilla or bukkit.

Comment by Kumasasa [ 23/Jul/13 ]

Is this still a concern in the current Minecraft version 1.6.2 ? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Comment by ItsMartin [ 31/Mar/13 ]

Sorry, I see that now. I didn't realise that jira doesn't show those changes in the default tab.

Comment by Thue [ 31/Mar/13 ]

I tested for 1.5, and from the changelog have no reason to think it was fixed in 1.5.1. It is a bit laborious to test, so I will probably not retest until 1.6, unless asked by the developers.

Comment by ItsMartin [ 30/Mar/13 ]

Time to test again?

Comment by Thue [ 06/Feb/13 ]

Unless it is important that you know RIGHT NOW, I will retest once 1.5 is out.

Comment by Tails [ 05/Feb/13 ]

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Comment by Thue [ 08/Nov/12 ]

Note that rfwadmin now has a 30 second sleep in the save function. Remove that before you try reproducing the bug using rfwadmin.

Generated at Sun Jan 12 11:58:10 UTC 2025 using Jira 9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13.