[MC-11280] Sometimes Water/Lava flows out of newly generated Village Farms / Forges Created: 08/Mar/13  Updated: 05/Jul/17  Resolved: 19/Nov/16

Status: Resolved
Project: Minecraft: Java Edition
Component/s: None
Affects Version/s: Minecraft 1.5, Minecraft 1.5.1, Snapshot 13w18c, Snapshot 13w19a, Snapshot 13w24a, Snapshot 13w24b, Snapshot 13w25a, Snapshot 13w25b, Snapshot 13w25c, Minecraft 1.6, Minecraft 1.6.2, Minecraft 1.8.8, Minecraft 15w49b
Fix Version/s: Minecraft 13w36a

Type: Bug
Reporter: Noah Gil Assignee: Unassigned
Resolution: Awaiting Response Votes: 18
Labels: None

Attachments: PNG File 2013-03-07_20.32.46.png     PNG File 2013-03-07_20.35.36.png     PNG File 2013-03-08_02.47.16.png     PNG File 2013-03-31_13.10.10.png     PNG File 2013-06-15_11.06.05.png    
Issue Links:
Duplicate
is duplicated by MC-11498 New water flow quirk Resolved
is duplicated by MC-11808 Water "spilling" out of an NPC villag... Resolved
is duplicated by MC-11879 Water and log glitch in Village Resolved
is duplicated by MC-11928 Water in Village Farm Flows Through W... Resolved
is duplicated by MC-12670 Water generation bug due to farm plot... Resolved
is duplicated by MC-13066 A world generation bug related to the... Resolved
is duplicated by MC-13138 SuperFlat Village block update error Resolved
is duplicated by MC-14546 water bug in village Resolved
is duplicated by MC-14589 Village Bug with Farms Resolved
is duplicated by MC-18136 water (without a source block) spawns... Resolved
is duplicated by MC-18516 Water flows through sandstone in rand... Resolved
is duplicated by MC-18540 "Leaky Water" Resolved
is duplicated by MC-18585 Water Spawns just outside of villager... Resolved
is duplicated by MC-18802 water is coming out of a village whea... Resolved
is duplicated by MC-18875 Flowing water without a Source block Resolved
is duplicated by MC-20429 I have been playing on super flat wor... Resolved
is duplicated by MC-21767 Water on NPC villages Resolved
is duplicated by MC-22321 Water Glitch Resolved
is duplicated by MC-23492 Water Bug/Village Resolved
is duplicated by MC-25483 Water is generating in villages outsi... Resolved
is duplicated by MC-26697 Liquids without source in world gener... Resolved
is duplicated by MC-29179 water Resolved
is duplicated by MC-35184 lava glitch in village Resolved
is duplicated by MC-77360 Lava flowing while disconnected from ... Resolved
is duplicated by MC-93915 Water Flow through Generated Blocks Resolved
is duplicated by MC-102117 Water leaks from village farms Resolved
Relates
relates to MC-55596 Some chunks in the same world seed se... Reopened
relates to MC-19375 Water in Jungle Temple Resolved
CHK:
Confirmation Status: Confirmed

 Description   

When I entered this village, I saw water comming out from the farm like there was a hole in the farm but there isn't.

See for yourself
seed: 5481915211951425789
x = 89
y = 52
z = 28
Flatland setting: 2;7,50x3,2;1;village


bugi74's possible explanation and what is important to know to reproduce this



 Comments   
Comment by Sealbudsman [ 05/Jul/17 ]

Since 1.8 at least, worldgen has been placing Stationary water and not Flowing, so that part of Markku's analysis (as he called it, the 'workaround') ended up not being effective as a solution.

Comment by [Mod] Michael Wobst [ 19/Nov/16 ]

Is this still an issue in the most recent versions (currently that is 1.11) of Minecraft? If so, please update the affected versions and help us keeping this ticket updated from time to time. If you are the owner/reporter of this ticket, you can modify the affected version(s) yourself.

Comment by bob [ 06/Nov/16 ]

Is this still an issue in the latest snapshot 16w44a?

Comment by Fabian Röling [ 15/Oct/16 ]

Does this still occur in the current versions?

Comment by Marcono1234 [ 18/May/16 ]

Please include bugi74's possible explanation and what is important to know to reproduce this

Comment by Markku [ 06/Dec/15 ]

IIRC, this bug was back then a slightly randomly appearing, as it depended in some cases on direction in which the user approached the village from, the exact chunks traveled (thus exact order of chunks generated), or even some timing related issues. Especially, warping directly on the village may fail to show the issue. It is best to teleport just outside the generation range of the village (note, it might not be the same as rendering distance), note which direction the approach is, see if issue happens. Note, even small (one chunk) differences in the approach (and thus chunk generation order) could affect the result.

To search for cases, it is best to just fly around in superflat, instead of regenerating the same world or same village. Only once the issue shows up, record the direction of movement and village location, and try to repeat with the same direction & village.

Happy leak hunting.

Comment by user-f2760 (Inactive) [ 06/Dec/15 ]

I had this a few days ago in my 15w49b server, going to provide seed and coords later, as I'm not on my pc now

Edit:
ok, weird, I generated a world with the same seed, got to the same coords, and now it wasn't there

Comment by Markku [ 20/Jul/13 ]

Probable reason
Going through those few cases where players have bothered to provide seeds, settings and locations, this seems to be a side-effect from the way "decorations" are added to world - shifted by half a chunk. Thus, when farms (or any other structures) are generated and inserted into the world, they can be inserted partially (cut at half-chunk positions), the other part(s) of the structure being inserted later, when player moves and allows generating more chunks. If the cutting happens to be next to a flowing block, there is half a chunk more space to flow into. Later when player moves, the other parts will overwrite some of the flowing water blocks without mercy, leaving the remnants as artifacts reported here.

Note, normal water generation is done per full chunk, and uses "still water" block, instead of "moving water" block. I do not know why, but in changing the village farm water blocks into "still water" type seems to fix the symptoms. Or more like, it is a workaround, since the real reason is the half a block shift (which causes more issues than just this one). Likely, the same could be applied to the "moving lava" used in one house, however, I do not have suitable test case for that.

A proper fix might be to implement some additional code that delays/prevents planting a structure (or a full independent part of a structure, depending on terminology) into the world until all of it can be planted at once, but that is beyond the scope of a comment here. However, this approach can have other nasty issues due to the way how some decorations will then be possibly planted when they shouldn't be, as they won't know about the delayed structure. (That last part is the roughly reason e.g. why lakes sometimes carve tree or building bottoms out; the trees/buildings do not know about the lake coming later...)

Here is example of workarounds, for those who want to test if it really works for them, too:

ComponentVillageField.addComponentParts()
        //this.fillWithBlocks(par1World, par3StructureBoundingBox, 3, 0, 1, 3, 0, 7, Block.waterMoving.blockID, Block.waterMoving.blockID, false);
        //this.fillWithBlocks(par1World, par3StructureBoundingBox, 9, 0, 1, 9, 0, 7, Block.waterMoving.blockID, Block.waterMoving.blockID, false);
        this.fillWithBlocks(par1World, par3StructureBoundingBox, 3, 0, 1, 3, 0, 7, Block.waterStill.blockID, Block.waterStill.blockID, false);
        this.fillWithBlocks(par1World, par3StructureBoundingBox, 9, 0, 1, 9, 0, 7, Block.waterStill.blockID, Block.waterStill.blockID, false);
ComponentVillageField2.addComponentParts()
        //this.fillWithBlocks(par1World, par3StructureBoundingBox, 3, 0, 1, 3, 0, 7, Block.waterMoving.blockID, Block.waterMoving.blockID, false);
        this.fillWithBlocks(par1World, par3StructureBoundingBox, 3, 0, 1, 3, 0, 7, Block.waterStill.blockID, Block.waterStill.blockID, false);
Comment by Pedro M. Zamboni [ 19/Jul/13 ]

happens with lava in blacksmith house's too. see images in MC-26697

Comment by Markku [ 10/Jul/13 ]

Still in 1.6.2

Comment by [Mod] Ezekiel (ezfe) [ 10/Jul/13 ]

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Comment by Alex de la Cruz [ 29/Jun/13 ]

I just opened a new world in 1.6.1 and saw this issue.

Comment by Allaiyah Weyn [ 25/Jun/13 ]

I started getting this on Superflat worlds after the last Snapshot.

I see tons of duplicate reports, but none of them return to vote. I suspect this issue won;t be touched for months.

Comment by Nicholas Chard [ 20/Jun/13 ]

I see this all the time.... also when taking away water sources, sometimes a corner acts as a source block

Comment by theonecynic [ 15/Jun/13 ]

Not just superflat worlds, here's one from largeBiomes. MC Version snapshot 13w24b. Seed 2028444982885494103, x=803, y=74, z=84.

Comment by 08Juan80 [ 01/Apr/13 ]

Added a screenshot of the village I found on a default superflat world I created.

Comment by Cameron [ 23/Mar/13 ]

happened to me to. I used Superflat though and it was at two villages. Seed:-60146107116314948 X:-1158 Y:14 Z:332 and X:-900 Y:9 Z:338

Comment by Markku [ 14/Mar/13 ]

Took quite a while to get my Eclipse accept the latest MCP (a setting was messing with JRE detection, had to figure that out first), and apparently the MCP result for 1.5 was sort of without proper field and method name deobfuscation. I guess it is a bit much to expect them to be done so soon after release

Anyway, this seems to be an elusive one. My first idea went down the drain, and the real cause is a mystery. However, I think I managed to get a workaround. The farm generation likes to use flowing water (no idea why or how they turn into source-blocks). I switched those to place directly source blocks, and could not reproduce this issue.

The already "leaking" things do remain in place even after the fix. This was expected and just means the state has been saved to the world and is not just some runtime bug or weird rendering issue.

I will delay deeper study on this until I get a bit more mature version of MCP. Hopefully Mojang will tackle it before that, as they can use change history etc. to speed up tracking potential causes.

Comment by Anon Ymus [ 08/Mar/13 ]

Also confirmed. Water disappears on block update.

Comment by Tails [ 08/Mar/13 ]

Confirmed. (/me waits on Markku's comment on this one)

Comment by Noah Gil [ 08/Mar/13 ]

seed: 5481915211951425789
x = 89
y = 52
z = 28
Flatland setting: 2;7,50x3,2;1;village

Comment by Tails [ 08/Mar/13 ]

Please provide seed and coordinates.

Generated at Sun Jan 12 12:27:08 UTC 2025 using Jira 9.12.2#9120002-sha1:301bf498dd45d800842af0b84230f1bb58606c13.