[MC-10369] Server side particle spawning does not create particles for client Created: 26/Feb/13 Updated: 08/Mar/23 Resolved: 02/Apr/19 |
|
| Status: | Resolved |
| Project: | Minecraft: Java Edition |
| Component/s: | None |
| Affects Version/s: | Snapshot 13w09a, Snapshot 13w09b, Snapshot 13w09c, Snapshot 13w10a, Snapshot 13w10b, Minecraft 1.5, Snapshot 13w11a, Minecraft 1.5.1, Snapshot 13w16a, Snapshot 13w16b, Minecraft 1.5.2, Snapshot 13w17a, Minecraft 1.6.2, Minecraft 1.7.4, Minecraft 14w05b, Minecraft 14w06b, Minecraft 14w07a, Minecraft 1.8, Minecraft 1.8.1-pre2, Minecraft 1.8.8, Minecraft 15w47c, Minecraft 1.8.9, Minecraft 16w06a, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.10.2, Minecraft 16w32b, Minecraft 1.11.2, Minecraft 1.12 Pre-Release 6, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 17w50a, Minecraft 18w05a, Minecraft 18w08b, Minecraft 18w11a, Minecraft 1.13-pre1, Minecraft 1.13-pre6, Minecraft 1.13.1 |
| Fix Version/s: | Minecraft 19w14a |
| Type: | Bug | ||
| Reporter: | Marcono1234 | Assignee: | [Mojang] Bartosz Bok |
| Resolution: | Fixed | Votes: | 31 |
| Labels: | 12w18a, iron_golem, particles, snow_golem, villager_golem | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| CHK: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Confirmation Status: | Confirmed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Category: |
(Unassigned)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
The bugParticle creation triggered for the server does not send a particle packets to the client. Affected situationsThe following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version. Iron and snow Golem creation
Wither boss creation
Water and lava colliding
Redstone torch burning out
Armor breaking on mob
Placing eye of ender in end portal frame
Animal being born
Ender dragon destroying blocks
Explosion particles for EntityLiving spawned by spawner
The reasonThe following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version. The reason why this is happening is because the abstract method net.minecraft.world.IWorldEventListener.spawnParticle(int, boolean, double, double, double, double, double, double, int...) is called for particle creation. Calling this method calls for the client the net.minecraft.client.renderer.RenderGlobal.spawnParticle(int, boolean, double, double, double, double, double, double, int...) method which creates the particle. However, for the server it calls the net.minecraft.world.WorldManager.spawnParticle(int, boolean, double, double, double, double, double, double, int...) method which does nothing. The change of using an integrated server for the client might have caused this bug. Comparing with old behaviourIf you would like to test how it was in 1.2.5, you can download the 1.2.5 jar file from here: |
| Comments |
| Comment by [Mod] tryashtar [ 27/Jan/20 ] |
|
Which of the examples are still an issue in 1.15.2? |
| Comment by KaptainWutax [ 04/Jan/19 ] |
|
So, a new item got added to the list in 1.9 : chorus fruit. When eaten, it calls Item#onItemUseFinish(ItemStack stack, World worldIn, EntityLivingBase entityLiving). That method then performs a !world.isRemote check and proceeds to call EntityLivingBase#attemptTeleport(double x, double y, double z) a couple of times. In the latter, the code generates PORTAL particles using the client-side spawnParticles method. But because of the server-side check earlier, nothing happens on the client and no packet is sent. |
| Comment by [Mod] tryashtar [ 23/Nov/17 ] |
|
Snow golem particles seem to be back in 17w47b, maybe earlier, though it's possible it's just a side effect of the snow blocks breaking. EDIT: yes it is, see |
| Comment by Sealbudsman [ 17/Mar/16 ] |
|
Affects version 1.9 and 1.9.1-pre3. |
| Comment by Marcono1234 [ 13/Mar/16 ] |
|
Can someone of the mods please mark all reports currently marked as "relates to" as duplicate? |
| Comment by [Mod] Les3awe [ 13/Feb/16 ] |
|
Reporter seems inactive. |
| Comment by Marcono1234 [ 11/Feb/16 ] |
|
Please link to this comment in the description The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version. The reason for this seems to be that the methods spawning the Snowman, VillagerGolem and WitherBoss (yes, a WitherBoss should – based on the code – also create particles) are only called server side, however the methods they are calling to create the particles are client side. This is a little bit complicated because they are calling the method for all net.minecraft.world.IWorldAccess. While for the client the net.minecraft.client.renderer.RenderGlobal (which creates the particles) is in this list, for the server only net.minecraft.world.WorldManager are in this list. The problem is their method for creating particles is simply doing nothing. This bug would be more obvious if there would be base, client and server classes for entities, blocks... and if the particle spawning method of the net.minecraft.client.renderer.RenderGlobal would be directly called. Anyways to solve this problem the method sending the particles packet to the client should be called: public void func_175739_a(EnumParticleTypes p_175739_1_, double p_175739_2_, double p_175739_4_, double p_175739_6_, int p_175739_8_, double p_175739_9_, double p_175739_11_, double p_175739_13_, double p_175739_15_, int ... p_175739_17_) of the net.minecraft.world.WorldServer class How to fix the bugInstead of having the for loops to create the particles, the following could / should be used: Snowman
VillagerGolem
WitherBoss
Note: In my opinion the particles should also be adjusted, so the VillagerGolem creates iron block breaking particles and the WitherBoss soul sand breaking particles. |
| Comment by Marcono1234 [ 11/Feb/16 ] |
|
Confirmed for
|
| Comment by Swekob [ 28/Nov/15 ] |
|
Affects 15w47c & 1.8.8 |
| Comment by [Mod] Sonicwave [ 20/Oct/14 ] |
|
Confirmed for 1.8/1.8.1-pre2. |
| Comment by HJS [ 18/Sep/14 ] |
|
you don't have to download the minecraft.jar for MC 1.2.5 you can use the launcher. |
| Comment by Tails [ 28/Mar/13 ] |
|
Confirmed. |
| Comment by Kumasasa [ 01/Mar/13 ] |
|
Chumbanotz, did you test every single issue against 13w09c in 2 minutes or do you blindly bulk-setting the version ? |