Uploaded image for project: 'Minecraft Launcher'
  1. Minecraft Launcher
  2. MCL-2964

Inherited JSON is overwritten when a library download takes place

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.5.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows 7 x64, Java 1.8.0_05 64-bit
    • Confirmation Status:
      Unconfirmed

      Description

      Summary

      When using a version with an inherited JSON, the original JSON is over-written with a "flattened" JSON if a library specified in the version or its parent is downloaded by the launcher.

      Steps to reproduce

      1. Create a version JSON which inherits from any other version, this example JSON file extends 1.7.10 and adds the ASM 5.0.3 library
        1.7.10-ASM.json
        {
          "id": "1.7.10-ASM",
          "time": "2014-05-14T18:29:23+01:00",
          "releaseTime": "2014-05-14T18:29:23+01:00",
          "type": "release",
          "libraries": [
            {
              "name": "org.ow2.asm:asm-all:5.0.3"
            }
          ],
          "minimumLauncherVersion": 16,
          "inheritsFrom": "1.7.10",
          "jar": "1.7.10"
        }
      2. Ensure that one or more libraries specified in the version is missing/requires download, for example delete the ASM 5.0.3 jar if it is already present
      3. Start the launcher and create a profile to use the new version
      4. Launch the game and observe that the original JSON is overwritten by a version which specifies all options from the parent version, and inheritance is lost.

      Additional tests

      I have confirmed that after the above procedure has been executed, the following corroborating test can be performed:

      1. Close the launcher and replace the contents of the JSON with the original
      2. Re-open the launcher and re-launch the game, this time no libraries should need to be downloaded
      3. The inherted JSON file remains intact

        Attachments

          Activity

            People

            • Assignee:
              dinnerbone [Mojang] Nathan Adams
              Reporter:
              mumfrey Adam Mummery-Smith
            • Votes:
              3 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: