The Bug:

Frosted ice doesn't hydrate farmland.

It's important to note that sugar cane can rely on frosted ice blocks in order to exist within the world therefore one would expect similar behavior with farmland. If frosted ice can be used to support the existence of sugar cane, one would expect that it would also be able to hydrate farmland.

I believe this could potentially be an issue because it creates a mild inconvenience for the player when they walk near their farms whilst wearing boots enchanted with frost walker. As a result of nearby water sources being converted into frosted ice, nearby farmland blocks will gradually lose their moisture level as frosted ice isn't seen as a valid block that can hydrate farmland. Because of this, the crops above the farmland grow slower, thus creating a minor annoyance.

Steps to Reproduce:

1. Build the setup as shown in the attachment below. setup.png
2. Set the time to "night" to avoid frosted ice from melting.
3. Replace the water within the setup with frosted ice by using the command provided below.

   /fill ~9 ~-1 ~9 ~-9 ~-4 ~-9 minecraft:frosted_ice replace minecraft:water

4. Wait around thirty seconds and observe the moisture levels of the farmland.
5. Take note as to whether or not frosted ice hydrates farmland.

Observed Behavior:

Frosted ice doesn't hydrate farmland.

Expected Behavior:

Frosted ice would hydrate farmland.

Code Analysis:

Code analysis by Avoma can be found below.

The following is based on a decompiled version of Minecraft 1.19.2 using MCP-Reborn.

public class FarmBlock extends Block {
   ...
   private static boolean isNearWater(LevelReader levelReader, BlockPos blockPos) {
      for(BlockPos blockpos : BlockPos.betweenClosed(blockPos.offset(-4, 0, -4), blockPos.offset(4, 1, 4))) {
         if (levelReader.getFluidState(blockpos).is(FluidTags.WATER)) {
            return true;
         }
      }
      return false;
   }
   ...

If we look at the above class, we can see that the isNearWater() boolean returns true if water fluid is present near farmland, and within the randomTick() method located elsewhere within the FarmBlock.java class, the isNearWater() boolean must return true in order for farmland blocks to be hydrated. The issue here is that the isNearWater() boolean only checks for the presence of water fluid and not frosted ice blocks before allowing farmland to be hydrated, therefore resulting in this problem occurring.

Fix:

Simply altering the existing "if" statement within this piece of code to also check for the nearby presence of frosted ice blocks before allowing farmland to be hydrated will resolve this problem.

if (levelReader.getFluidState(blockpos).is(FluidTags.WATER))

if (levelReader.getFluidState(blockpos).is(FluidTags.WATER) || levelReader.getBlockState(blockpos).is(Blocks.FROSTED_ICE))