Minecraft
  1. Minecraft
  2. MC-96544

Temperature Freezing Point Inconsistency

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 1.8.9, Minecraft 16w05a, Minecraft 16w05b, Minecraft 16w06a, Minecraft 16w07a, Minecraft 16w07b, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3
    • Fix Version/s: Minecraft 16w41a
    • Security Level: Minecraft - Public (Viewable by everyone)
    • Labels:
      None
    • Confirmation Status:
      Unconfirmed

      Description

      While the "freezing point" of water source blocks and rain was made to be .15f for Minecraft 1.7 (previously had two different values (.15f, .2f)), the specific usage of this temperature value is still inconsistent – in some places in the code, "freezing" is less than or equal to .15f, while in other places it is less than .15f (and not equal to).

      While biomes cannot normally have temperatures between .1f and .2f, meaning this issue has no effect in pure vanilla, add-ons that manipulate biome temperature can expose this vanilla bug the y-based temperature degradation and x/z-based perlin noise can drop the effective temperature to 0.15F from as much as 0.4749F.

      I wrote a simple mod to highlight the locations it manifests in - it makes the entire world an Extreme Hills biome, disables snow tile placement, and places an orange stained clay block directly under the places that have a temperature of exactly 0.15F. After generating the world, I shut down my game and loaded it back up in vanilla.

      http://imgur.com/a/9dVSK
      The first picture is an aerial view of the effected block locations (at least in Extreme Hills) while the second picture is of the rain falling (without my worldgen mod, taken in the latest snapshot - 16w05b).
      If you want a copy of the world to check out for yourself, I still have it. I forgot to disable mineshafts, but it's still easy to check and verify that I'm showing this in pure vanilla and without command blocks.

      With this bug, rain animation and audio is played, yet snow tiles form.

      To make fixing it as simple a process as possible, these are all of them in 1.9:

      >= .15f is not freezing
      bng.p()V (source line 1399; weather/shader rendering class, smoke and rain particles)
      bng.c(F)V (source line 1500; weather/shader rendering class, rain/snow rendering)
      < .15f is freezing
      akd.h(Laht;Lcj;)V (source line 198)
      aig.b(Laht;Ljava/util/Random;Latf;IID)V (source line 302; base biome class, used for worldgen)

      > .15f is not freezing
      aht.e(Lcj;Z)Z (source line 2031; base world class, can block freeze at location)
      aht.f(Lcj;Z)Z (source line 2059; base world class, can it snow at location)

        Activity

        Hide
        [Mod] redstonehelper added a comment -

        Not really a bug in vanilla, it has no effect on the game.

        Show
        [Mod] redstonehelper added a comment - Not really a bug in vanilla, it has no effect on the game.
        Hide
        David F-S added a comment -

        I retract my previous statement that this bug doesn't effect anything in vanilla. I thought it didn't, but I realized I was mistaken as I became more intimate with the bug's hidden details.

        I wrote a simple mod to highlight the locations it manifests in - it makes the entire world an Extreme Hills biome, disables snow tile placement, and places an orange stained clay block directly under the places that have a temperature of exactly 0.15F. After generating the world, I shut down my game and loaded it back up in vanilla.

        http://imgur.com/a/9dVSK
        The first picture is an aerial view of the effected block locations (at least in Extreme Hills) while the second picture is of the rain falling (without my worldgen mod, taken in the latest snapshot - 16w05b).
        If you want a copy of the world to check out for yourself, I still have it. I forgot to disable mineshafts, but it's still easy to check and verify that I'm showing this in pure vanilla and without command blocks.

        With this bug, rain animation and audio is played, yet snow tiles form.

        To make fixing it as simple a process as possible, these are all of them in 16w05a:

        >= .15f is not freezing
        bne.p()V (source line 1399; weather/shader rendering class, smoke and rain particles)
        bne.c(F)V (source line 1500; weather/shader rendering class, rain/snow rendering)
        < .15f is freezing
        aka.h(Lahq;Lcj;)V (source line 198)
        aid.b(Lahq;Ljava/util/Random;Latd;IID)V (source line 302; base biome class, used for worldgen)

        > .15f is not freezing
        ahq.e(Lcj;Z)Z (source line 2030; base world class, can block freeze at location)
        ahq.f(Lcj;Z)Z (source line 2058; base world class, can it snow at location)

        Show
        David F-S added a comment - I retract my previous statement that this bug doesn't effect anything in vanilla. I thought it didn't, but I realized I was mistaken as I became more intimate with the bug's hidden details. I wrote a simple mod to highlight the locations it manifests in - it makes the entire world an Extreme Hills biome, disables snow tile placement, and places an orange stained clay block directly under the places that have a temperature of exactly 0.15F. After generating the world, I shut down my game and loaded it back up in vanilla. http://imgur.com/a/9dVSK The first picture is an aerial view of the effected block locations (at least in Extreme Hills) while the second picture is of the rain falling (without my worldgen mod, taken in the latest snapshot - 16w05b). If you want a copy of the world to check out for yourself, I still have it. I forgot to disable mineshafts, but it's still easy to check and verify that I'm showing this in pure vanilla and without command blocks. With this bug, rain animation and audio is played, yet snow tiles form. To make fixing it as simple a process as possible, these are all of them in 16w05a: >= .15f is not freezing bne.p()V (source line 1399; weather/shader rendering class, smoke and rain particles) bne.c(F)V (source line 1500; weather/shader rendering class, rain/snow rendering) < .15f is freezing aka.h(Lahq;Lcj;)V (source line 198) aid.b(Lahq;Ljava/util/Random;Latd;IID)V (source line 302; base biome class, used for worldgen) > .15f is not freezing ahq.e(Lcj;Z)Z (source line 2030; base world class, can block freeze at location) ahq.f(Lcj;Z)Z (source line 2058; base world class, can it snow at location)
        Hide
        [Mod] redstonehelper added a comment -

        Good work, reopened.

        Show
        [Mod] redstonehelper added a comment - Good work, reopened.
        Hide
        David F-S added a comment -

        What more can I do to help get this fixed? It's a pathetically simple problem that would only take moments to correct, and I've even pointed out where in the code it's coming from (down to the line numbers in the source files, at that. I've even described what the classes are for, so that it's even not necessary to look through obfuscation logs). What else would help get this perfectly valid bug finally fixed?

        Show
        David F-S added a comment - What more can I do to help get this fixed? It's a pathetically simple problem that would only take moments to correct, and I've even pointed out where in the code it's coming from (down to the line numbers in the source files, at that. I've even described what the classes are for, so that it's even not necessary to look through obfuscation logs). What else would help get this perfectly valid bug finally fixed?
        Hide
        [Mod] FVbico (Steven Verberne) added a comment -

        keeping the effected versions up to date, that's the only thing left you can do to help with the issue

        Show
        [Mod] FVbico (Steven Verberne) added a comment - keeping the effected versions up to date, that's the only thing left you can do to help with the issue

          People

          • Assignee:
            [Mojang] Agnes Larsson
            Reporter:
            David F-S
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: