Minecraft
  1. Minecraft
  2. MC-93651

No placement sound when placing blocks on fence

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 15w49a, Minecraft 15w49b, Minecraft 15w50a, Minecraft 15w51b, Minecraft 16w02a, Minecraft 16w03a, Minecraft 16w04a, Minecraft 16w05a, Minecraft 16w05b, Minecraft 16w06a, Minecraft 16w07a, Minecraft 16w07b, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.9.1, Minecraft 1.9.2, Minecraft 16w14a, Minecraft 16w15a, Minecraft 16w15b, Minecraft 1.9.3 Pre-Release 1, Minecraft 1.9.3 Pre-Release 2, Minecraft 1.9.3 Pre-Release 3, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 16w21a, Minecraft 16w21b, Minecraft 1.10 Pre-Release 1, Minecraft 1.10 Pre-Release 2, Minecraft 1.10, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 16w35a, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b
    • Fix Version/s: Minecraft 16w39c
    • Security Level: Minecraft - Public (Viewable by everyone)
    • Labels:
      None
    • Environment:

      Java 1.8.0_65 64bit.
      Windows 7 64bit.

    • Confirmation Status:
      Confirmed

      Description

      Code analysis by [Helper] Marcono1234 can be found in this comment.

        Issue Links

          Activity

          Hide
          [Helper] Pokechu22 added a comment -

          Underlying cause is MC-21433 (which is WIA :/)

          Show
          [Helper] Pokechu22 added a comment - Underlying cause is MC-21433 (which is WIA :/)
          Hide
          [Helper] Marcono1234 added a comment -

          That is not quite the problem here as the block is placed. The problem is that the client always asumes that it interacted with the fence whereas the server does not behave like this and places the block.

          Show
          [Helper] Marcono1234 added a comment - That is not quite the problem here as the block is placed. The problem is that the client always asumes that it interacted with the fence whereas the server does not behave like this and places the block.
          Hide
          [Helper] Pokechu22 added a comment -

          Read the comments on that issue. They're the same effectively (it's just that the issue title is not as detailed). The full title I'd give to MC-21433 is "Fences are always interactive blocks clientside".

          To put it another way, the fix you're suggesting (which I approve of) would also fix MC-21433.

          Show
          [Helper] Pokechu22 added a comment - Read the comments on that issue. They're the same effectively (it's just that the issue title is not as detailed). The full title I'd give to MC-21433 is "Fences are always interactive blocks clientside". To put it another way, the fix you're suggesting (which I approve of) would also fix MC-21433 .
          Hide
          [Helper] Marcono1234 added a comment -

          Sorry, yes you are right. I thought they acted the same way iron doors or trapdoors act.

          Mods please do not close this report as a duplicate because then we have an unnecessary discussion about whether or not it is WAI and like [Helper] Pokechu22 said it is definitely not.

          I would suggest fixing it by having client and server call the method net.minecraft.item.ItemLead.attachToFence(EntityPlayer, World, BlockPos) but change this method to only create the LeashKnot and leash the entity server-side.

          Note: The method net.minecraft.item.ItemLead.onItemUse(ItemStack, EntityPlayer, World, BlockPos, EnumHand, EnumFacing, float, float, float) contains kind of dead code because if the player successfully interacts with a block it will not use the item. If the player fails right clicking while holding a leash, this method will fail as well.

          Show
          [Helper] Marcono1234 added a comment - Sorry, yes you are right. I thought they acted the same way iron doors or trapdoors act. Mods please do not close this report as a duplicate because then we have an unnecessary discussion about whether or not it is WAI and like [Helper] Pokechu22 said it is definitely not. I would suggest fixing it by having client and server call the method net.minecraft.item.ItemLead.attachToFence(EntityPlayer, World, BlockPos) but change this method to only create the LeashKnot and leash the entity server-side. Note: The method net.minecraft.item.ItemLead.onItemUse(ItemStack, EntityPlayer, World, BlockPos, EnumHand, EnumFacing, float, float, float) contains kind of dead code because if the player successfully interacts with a block it will not use the item. If the player fails right clicking while holding a leash, this method will fail as well.
          Hide
          [Helper] violine1101 added a comment -

          Still in 16w38a.

          Show
          [Helper] violine1101 added a comment - Still in 16w38a.

            People

            • Assignee:
              [Mojang] Grum (Erik Broes)
              Reporter:
              Moore M
            • Votes:
              98 Vote for this issue
              Watchers:
              32 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                CHK: