Uploaded image for project: 'Minecraft'
  1. Minecraft
  2. MC-92165

Minecarts won't pick up entities

    Details

    • Type: Bug
    • Status: Reopened
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 15w45a, Minecraft 15w46a, Minecraft 15w47a, Minecraft 15w47c, Minecraft 15w50a, Minecraft 15w51a, Minecraft 15w51b, Minecraft 16w02a, Minecraft 16w03a, Minecraft 16w04a, Minecraft 16w05b, Minecraft 16w06a, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.9.1, Minecraft 1.9.2, Minecraft 1.9.3 Pre-Release 3, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 16w21b, Minecraft 1.10 Pre-Release 1, Minecraft 1.10 Pre-Release 2, Minecraft 1.10, Minecraft 1.10.1, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 16w35a, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b, Minecraft 16w39c, Minecraft 16w40a, Minecraft 16w41a, Minecraft 16w42a, Minecraft 16w43a, Minecraft 16w44a, Minecraft 1.11 Pre-Release 1, Minecraft 1.11, Minecraft 16w50a, Minecraft 1.11.2, Minecraft 17w06a, Minecraft 17w13b, Minecraft 17w14a, Minecraft 17w15a, Minecraft 17w16a, Minecraft 17w16b, Minecraft 17w17a, Minecraft 17w17b, Minecraft 17w18a, Minecraft 17w18b, Minecraft 1.12 Pre-Release 1, Minecraft 1.12 Pre-Release 2, Minecraft 1.12 Pre-Release 3, Minecraft 1.12 Pre-Release 4, Minecraft 1.12 Pre-Release 5
    • Fix Version/s: Minecraft 16w21a
    • Labels:
      None
    • Environment:

      Win 8.1, Java 8u65-x64

    • Confirmation Status:
      Confirmed

      Description

      Moving minecarts will sometimes not pick up entities placed on the rails.

      I asked Panda for his help and talked about the findings/patterns of this problem, and after a a thorough code analysis it turns out that after the recent fix there are still a few issues with how Minecarts pick up entities.

      There are mainly two issues:
      1. Armourstands don't get picked up by Minecarts but instead get moved by them (only by empty ones)
      2. Other entities don't always get picked up. Sometimes the Minecart just stops instead.

      The first issue should be rather simple to fix by adjusting some checks.

      The second issue happens due to the Minecart colliding with the entity and stopping, before the code that is responsible for the pickup.
      A possible way to fix this would be to do the pickup-check before the collision check that makes the Minecart stop at entities or blocks and expand the bounding box into the moving direction. It's a bit tricky to find a good fix for this as the movement and the collision are calculated together in the entity class.

      Credits for code-reading to Panda 😸
      I hope it can be fixed now, these collision checks seem to be tricky, and I'm not sure if the suggested solution will be a 100% fix, but we'll wait, see and hope };]

      In case the next bugfix won't work 100% as well because we overlooked something, we are willing to try to help again, as this is a very important bug to be fixed for the community.


      Reddit thread:
      https://www.reddit.com/r/Mojira/comments/459vtt/are_the_new_limited_minecarts_definitive

      Video:
      https://youtu.be/d0EQvFNb9bQ


      Code analysis by [Helper] Marcono1234 can be found in this comment.

        Attachments

        1. 2016-05-29_10.56.20.png
          2016-05-29_10.56.20.png
          564 kB
        2. 2016-05-29_10.57.31.png
          2016-05-29_10.57.31.png
          443 kB
        3. 2016-05-29_11.05.31.png
          2016-05-29_11.05.31.png
          747 kB
        4. 2016-05-29_11.05.38.png
          2016-05-29_11.05.38.png
          731 kB
        5. 2016-05-29_11.18.40.png
          2016-05-29_11.18.40.png
          189 kB
        6. 2016-05-29_11.31.53.png
          2016-05-29_11.31.53.png
          122 kB
        7. 2016-05-29_14.01.03.png
          2016-05-29_14.01.03.png
          207 kB
        8. 2016-05-29_14.04.54.png
          2016-05-29_14.04.54.png
          193 kB
        9. 2016-05-29_14.14.06.png
          2016-05-29_14.14.06.png
          137 kB
        10. 2016-05-29_14.30.05.png
          2016-05-29_14.30.05.png
          139 kB
        11. 2016-05-29_14.38.30.png
          2016-05-29_14.38.30.png
          110 kB
        12. 2016-05-29_14.39.01.png
          2016-05-29_14.39.01.png
          71 kB
        13. 2016-05-29_14.49.11.png
          2016-05-29_14.49.11.png
          58 kB
        14. MC-92165_entitiyPickupLocations.png
          MC-92165_entitiyPickupLocations.png
          150 kB

          Issue Links

            Activity

              People

              • Assignee:
                grum [Mojang] Grum (Erik Broes)
                Reporter:
                LapisDemon Meri Diana
              • Votes:
                188 Vote for this issue
                Watchers:
                86 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: