Uploaded image for project: 'Minecraft'
  1. Minecraft
  2. MC-92165

Minecarts with high motion won't pick up entities

    Details

    • Type: Bug
    • Status: Reopened
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 15w45a, Minecraft 15w46a, Minecraft 15w47a, Minecraft 15w47c, Minecraft 15w50a, Minecraft 15w51a, Minecraft 15w51b, Minecraft 16w02a, Minecraft 16w03a, Minecraft 16w04a, Minecraft 16w05b, Minecraft 16w06a, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.9.1, Minecraft 1.9.2, Minecraft 1.9.3 Pre-Release 3, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 16w21b, Minecraft 1.10 Pre-Release 1, Minecraft 1.10 Pre-Release 2, Minecraft 1.10, Minecraft 1.10.1, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 16w35a, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b, Minecraft 16w39c, Minecraft 16w40a, Minecraft 16w41a, Minecraft 16w42a, Minecraft 16w43a, Minecraft 16w44a, Minecraft 1.11 Pre-Release 1, Minecraft 1.11, Minecraft 16w50a, Minecraft 1.11.2, Minecraft 17w06a, Minecraft 17w13b, Minecraft 17w14a, Minecraft 17w15a, Minecraft 17w16a, Minecraft 17w16b, Minecraft 17w17a, Minecraft 17w17b, Minecraft 17w18a, Minecraft 17w18b, Minecraft 1.12 Pre-Release 1, Minecraft 1.12 Pre-Release 2, Minecraft 1.12 Pre-Release 3, Minecraft 1.12 Pre-Release 4, Minecraft 1.12 Pre-Release 5, Minecraft 1.12 Pre-Release 6, Minecraft 1.12 Pre-Release 7, Minecraft 1.12
    • Fix Version/s: Minecraft 16w21a
    • Confirmation Status:
      Confirmed

      Description

      The bug

      Minecart with high motion values are not able to pick up entities. Instead they just collide with them and stop.

      Note: Armor stands are a special case which is described in MC-90923.

      How to reproduce

      1. Place multiple powered rails behind each other and power them
      2. Spawn for example a pig somewhere on the track
      3. Place a minecart at least two blocks away from the pig on the track and push it towards the pig

      Code analysis

      Partwise by Panda

      Based on 1.12 decompiled using MCP 9.40 PRE 1

      The problem is that the picking up of entities happens in the method net.minecraft.entity.item.EntityMinecart.onUpdate() while the minecart is moved and stopped in the method net.minecraft.entity.Entity.moveEntity(MoverType, double, double, double). The onUpdate() method already uses an extended bounding box to pick up entities but if it has a high motion this extending is not enough. Increasing it even further might cause other problems.

      Maybe the method Entity.moveEntity could call some methods for handling collision with entities.

        Attachments

        1. 2016-05-29_10.56.20.png
          2016-05-29_10.56.20.png
          564 kB
        2. 2016-05-29_10.57.31.png
          2016-05-29_10.57.31.png
          443 kB
        3. 2016-05-29_11.05.31.png
          2016-05-29_11.05.31.png
          747 kB
        4. 2016-05-29_11.05.38.png
          2016-05-29_11.05.38.png
          731 kB
        5. 2016-05-29_11.18.40.png
          2016-05-29_11.18.40.png
          189 kB
        6. 2016-05-29_11.31.53.png
          2016-05-29_11.31.53.png
          122 kB
        7. 2016-05-29_14.01.03.png
          2016-05-29_14.01.03.png
          207 kB
        8. 2016-05-29_14.04.54.png
          2016-05-29_14.04.54.png
          193 kB
        9. 2016-05-29_14.14.06.png
          2016-05-29_14.14.06.png
          137 kB
        10. 2016-05-29_14.30.05.png
          2016-05-29_14.30.05.png
          139 kB
        11. 2016-05-29_14.38.30.png
          2016-05-29_14.38.30.png
          110 kB
        12. 2016-05-29_14.39.01.png
          2016-05-29_14.39.01.png
          71 kB
        13. 2016-05-29_14.49.11.png
          2016-05-29_14.49.11.png
          58 kB
        14. MC-92165_entitiyPickupLocations.png
          MC-92165_entitiyPickupLocations.png
          150 kB

          Issue Links

            Activity

              People

              • Assignee:
                grum [Mojang] Grum (Erik Broes)
                Reporter:
                LapisDemon Meri Diana
              • Votes:
                190 Vote for this issue
                Watchers:
                84 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: