Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-89030

Pistons warp entities too much (Pistons pull entities in/through blocks)

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 15w38b, Minecraft 15w39b, Minecraft 15w39c, Minecraft 15w40a, Minecraft 15w41b, Minecraft 15w42a, Minecraft 15w43c, Minecraft 15w44a, Minecraft 15w44b, Minecraft 15w45a, Minecraft 15w46a, Minecraft 15w47a, Minecraft 15w47b, Minecraft 15w47c, Minecraft 15w49a, Minecraft 15w49b, Minecraft 15w50a, Minecraft 15w51b, Minecraft 16w06a, Minecraft 1.9 Pre-Release 1, Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.9.1, Minecraft 1.9.2, Minecraft 16w14a, Minecraft 16w15a, Minecraft 16w15b, Minecraft 1.9.3 Pre-Release 1, Minecraft 1.9.3 Pre-Release 2, Minecraft 1.9.3 Pre-Release 3, Minecraft 1.9.3, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 16w21a, Minecraft 16w21b, Minecraft 1.10 Pre-Release 1, Minecraft 1.10 Pre-Release 2, Minecraft 1.10, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 16w35a, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b, Minecraft 16w39c
    • Fix Version/s: Minecraft 16w40a
    • Labels:
      None
    • Confirmation Status:
      Confirmed

      Description

      Since the recent changes to block 36, entities that get pushed get set right in front of the block 36 collision box.
      That makes sense, but it should only happen for entities which collision box is (almost) fully in front of the block 36.
      Otherwise entities that just barely reach inside the block 36 from behind get warped in front of it.

      Steps to reproduce:
      1. Build up 2015-09-18_23.35.57.png
      2. Remove the redstone block 2015-09-18_23.36.12.png
      3. Place the redstone block
      4. The armour stand got warped on top of the half slab 2015-09-18_23.36.19.png

      This behaviour is kind of cool for the technical community, but it doesn't look intended, so better fix it fast before we get used to it

      Making pistons work perfectly is a bit trickier than I though. I had a fix here, but it wouldn't have worked well in some cases either. So for now here is a list of points that might help:

      • block 36 should use the list of collision boxes the block it holds has (currently it's just the rendering hitbox, I believe)
      • to the outside block 36 probably should give of the hixbox it would have after finishing the current step, otherwise block-air-block can cause an entity that stands in the air block to get stuck on one of the block 36 and therefore getting inside the other block
      • block 36 should only move entities in front of it, not all intersecting
      • cauldrons should be able to keep a mob inside while moving (this is a good test if the code is working in the most difficult cases)

      Hopefully I will get to update this to more useful info soon.

        Attachments

        1. 2015-09-18_23.35.57.png
          2015-09-18_23.35.57.png
          100 kB
        2. 2015-09-18_23.36.12.png
          2015-09-18_23.36.12.png
          93 kB
        3. 2015-09-18_23.36.19.png
          2015-09-18_23.36.19.png
          97 kB
        4. 2015-12-01-1125-58.flv
          2.30 MB
        5. 2016-03-15_20.52.10.png
          2016-03-15_20.52.10.png
          558 kB
        6. 2016-03-15_20.57.47.png
          2016-03-15_20.57.47.png
          499 kB
        7. Minecraft 15w47c =20_11_2015= 20_14_45 [PM].mp4
          3.82 MB

          Issue Links

            Activity

              People

              • Assignee:
                grum [Mojang] Grum (Erik Broes)
                Reporter:
                panda4994 Panda
              • Votes:
                108 Vote for this issue
                Watchers:
                78 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  CHK: