Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-76057

Looting combines with Silk Touch but not vice versa

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 1.8.1, Minecraft 1.8.2-pre1, Minecraft 1.8.2-pre4, Minecraft 1.8.6, Minecraft 1.8.7, Minecraft 1.8.8, Minecraft 15w36d, Minecraft 15w39b, Minecraft 1.9.4, Minecraft 1.10, Minecraft 16w41a, Minecraft 16w43a, Minecraft 16w44a, Minecraft 1.11, Minecraft 16w50a
    • Fix Version/s: Minecraft 1.11.1
    • Labels:
      None
    • Environment:

      Java 8u25 on OS X 10.9.5

    • Confirmation Status:
      Confirmed

      Description

      Get an anvil and books for Looting and Silk Touch (any level). Put Looting in the left slot and Silk Touch in the right slot. Take a peek at the resulting book to verify that they will combine. Now swap the two books so Silk Touch is in the left slot and Looting is in the right slot. The resulting book will be only Silk Touch. The same happens when you substitute Luck of the Sea for Looting. Fortune won't combine either way.

      Not that there's really any point to this, but it's a remarkable inconsistency. It stems from the way Silk Touch and Fortune are prevented from combining. I can see you'd block that combination because Silk Touch would preempt Fortune anyway. But it isn't implemented correctly. Fortune, Looting, and Luck of the Sea are all represented by the same class. If you ask that class whether it will combine with Silk Touch, it refuses regardless of which of the three enchantments it represents. If you ask Silk Touch, it only refuses if the other enchantment is Fortune specifically.

      I'm calling to allow Silk Touch + Looting/LoTS, not disallow Looting/LoTS + Silk Touch. This is to be consistent with all other enchantments that are incompatible by virtue of applying to different sets of tools, which simply combine. Enchanting tables also naturally produce combinations like Smite + Protection (or, indeed, potentially Looting + Silk Touch) on books. This apparent impossibility is resolved when the book is applied to an item (sword only getting Smite or armor only getting Protection). I'm not too fond of this forced disposal of costly enchantments, but consistency is paramount. Alternatively, you could block all nonsensical combinations, not just these two.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jonathan2520 jonathan2520
              • Votes:
                3 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  CHK: