Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-51150

Swimming in water, riding a minecart or standing on soul sand and snow layers 8 darkens the sky at day time

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 14w11b, Minecraft 14w34d, Minecraft 1.8, Minecraft 1.8.1-pre4, Minecraft 1.8.1, Minecraft 1.8.3, Minecraft 1.8.4, Minecraft 1.8.5, Minecraft 1.8.6, Minecraft 1.8.8, Minecraft 15w31a, Minecraft 15w31c, Minecraft 15w44b, Minecraft 1.9, Minecraft 1.9.4, Minecraft 16w20a, Minecraft 1.10.2, Minecraft 16w32a, Minecraft 16w32b, Minecraft 16w33a, Minecraft 1.11.2, Minecraft 17w06a, Minecraft 1.12 Pre-Release 5, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 17w43a, Minecraft 17w43b, Minecraft 17w50a, Minecraft 18w01a, Minecraft 18w06a, Minecraft 18w07a, Minecraft 1.13-pre1, Minecraft 1.13, Minecraft 18w30b
    • Fix Version/s: Minecraft 1.13.1-pre1
    • Labels:
      None
    • Confirmation Status:
      Confirmed

      Description

      The bug

      In some situations the sky darkens when it shouldn't.

      Affected situations

      Likely incomplete

      • Sitting in a minecart or boat
      • Swimming in water
      • Standing on soul sand and snow layers 8

      Code analysis and possible fix

      The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.

      Source

      Forge code changes

      float f3 = this.mc.world.getLightBrightness(new BlockPos(this.mc.getRenderViewEntity()));
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                BriTheNinja Brian Tyler
              • Votes:
                37 Vote for this issue
                Watchers:
                20 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  CHK: