Minecraft
  1. Minecraft
  2. MC-47744

Cannot disable experience from villager trades

    Details

    • Confirmation Status:
      Unconfirmed

      Description

      Before you close this as "feature request", Grum asked for a ticket so he doesn't forget. Also, Jeb previously considered it and suggested how it would be fixed.

      The issue: mapmakers and server owners cannot disable experience received from trading villagers. This drastically breaks the balance of some maps, as shown in the attached GIF.

      The fix, proposed by Jeb, is to add a per-offer NBT tag determining whether or not that offer can give the player experience. This would allow mapmakers and server owners to manually disable trading XP from custom villagers.

      Again, I'm only posting this because Grum wanted to know if it has a ticket, and didn't want to forget about it. I don't think closing this will help, but I suppose Grum will re-open it if he wants it to stay open.

        Issue Links

          Activity

          Hide
          Ken Halterman added a comment -

          I have another posted https://bugs.mojang.com/browse/MC-47770

          Your post is a bit better, voted.

          Show
          Ken Halterman added a comment - I have another posted https://bugs.mojang.com/browse/MC-47770 Your post is a bit better, voted.
          Hide
          [Mojang] Dinnerbone (Nathan Adams) added a comment -

          "rewardExp" (boolean) is now part of an individual trade

          Show
          [Mojang] Dinnerbone (Nathan Adams) added a comment - "rewardExp" (boolean) is now part of an individual trade
          Hide
          Warren Liddell added a comment - - edited

          Could you be a little more specific about where abouts this code is put into the custom villager code?

          e.g of a custom villager out of 12 i have is @ http://pastebin.com/D2aNgbyJ

          Show
          Warren Liddell added a comment - - edited Could you be a little more specific about where abouts this code is put into the custom villager code? e.g of a custom villager out of 12 i have is @ http://pastebin.com/D2aNgbyJ
          Hide
          WolfieMario added a comment -

          Thank you so much, Dinnerbone! (And Grum too, for letting us post this ticket!)


          @Warren:

          My guess is you'd put "rewardExp:false," before every "maxUses" in your code. Also, just so you know, this last bit you have is now useless:

          {maxUses:0,buy:{id:bedrock,Count:1},sell:{id:bedrock,Count:1}}]}

          It won't stop the villager from generating new trades anymore. Instead, after the villager's "Profession:0," tag, add "Career:1,CareerLevel:50,". As of right now, that will prevent the villager from making new trades; I hope it stays that way in future versions too.

          Show
          WolfieMario added a comment - Thank you so much, Dinnerbone! (And Grum too, for letting us post this ticket!) @Warren: My guess is you'd put "rewardExp:false," before every "maxUses" in your code. Also, just so you know, this last bit you have is now useless: {maxUses:0,buy:{id:bedrock,Count:1},sell:{id:bedrock,Count:1}}]} It won't stop the villager from generating new trades anymore. Instead, after the villager's "Profession:0," tag, add "Career:1,CareerLevel:50,". As of right now, that will prevent the villager from making new trades; I hope it stays that way in future versions too.
          Hide
          Warren Liddell added a comment - - edited

          @Wolfie:

          Yeah i thought that was well, but sadly that didnt work as i had tried it there and after that, before/after the buy/sell an i still gained XP with the trades. The career tag etc has all ready been implemented to stop new trades from occuring, i just hadnt updated my txt file with the updated code as i have all villagers pickblocked with the NBT data in my enderchest.

          So im actually wondering if its currently implemented or if its implemented as of the next snapshot

          Show
          Warren Liddell added a comment - - edited @Wolfie: Yeah i thought that was well, but sadly that didnt work as i had tried it there and after that, before/after the buy/sell an i still gained XP with the trades. The career tag etc has all ready been implemented to stop new trades from occuring, i just hadnt updated my txt file with the updated code as i have all villagers pickblocked with the NBT data in my enderchest. So im actually wondering if its currently implemented or if its implemented as of the next snapshot
          Hide
          WolfieMario added a comment -

          It says "Fix Version/s: Future Version - 1.8?", meaning it's implemented in the next snapshot.

          i have all villagers pickblocked with the NBT data in my enderchest.

          I'm not sure what you're saying here - it's possible to pickblock the NBT data of entities now? Does that make a spawn egg with the entity's NBT data?

          Show
          WolfieMario added a comment - It says "Fix Version/s: Future Version - 1.8?", meaning it's implemented in the next snapshot. i have all villagers pickblocked with the NBT data in my enderchest. I'm not sure what you're saying here - it's possible to pickblock the NBT data of entities now? Does that make a spawn egg with the entity's NBT data?
          Hide
          Warren Liddell added a comment -

          I have all the commandblocks with the villager data in them pickblocked.

          Show
          Warren Liddell added a comment - I have all the commandblocks with the villager data in them pickblocked.

            People

            • Assignee:
              [Mojang] Dinnerbone (Nathan Adams)
              Reporter:
              WolfieMario
            • Votes:
              6 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: