XMLWordPrintable

    Details

    • Confirmation Status:
      Confirmed

      Description

      Between Snapshot 13w41b and 13w42a, Wobble shader was modified. However, there was an error in the change which breaks the shader, preventing it from working.

      What I expected to happen was...:
      When utilizing the Super Secret Settings button, it would eventually cycle shaders to Wobble, which could be observed.

      What actually happened was...:
      No shader is visible, and the console does not note that the shader has been cycled to, staying as "Blur" until pressed again and moving to the next shader instead.

      Specifics on cause and how to fix:
      The problem is wobble.fsh was changed between these versions to attempt to preserve the Alpha channel (Previously, it defaulted Alpha to 1.0 instead of passing the current Alpha value along, which was likely incompatible with new transparency). To do this, (among other changes) a line was changed from vec3 to vec4. However, ".rgb" was not removed from the end of this now vec4 varable, which causes it to only pass 3 (rgb) values when vec4 requires 4 values (rgba). This causes an error, breaking the shader.

      This is a simple fix: Simply remove ".rgb" from the vec4 line. I have just tested this by copying the file into a resource pack and committing this change. The shader functions normally again.

      Steps to Reproduce:
      1. Press Super Secret Settings button until you get to Blur
      2. Press again
      3. F3 will still indicate Blur as the selected shader and the console will note an error

      Example (13w41b):
      vec3 rgb = texture2D(DiffuseSampler, texCoord + offset).rgb;

      Example (13w42a):
      vec4 rgb = texture2D(DiffuseSampler, texCoord + offset).rgb;

      Fixed line:
      vec4 rgb = texture2D(DiffuseSampler, texCoord + offset);


      Client> [00:07:16] [Client thread/INFO]: Selecting effect minecraft:shaders/post/wobble.json
      Client> [00:07:16] [Client thread/WARN]: Failed to load shader: minecraft:shaders/post/wobble.json
      Client> kq: Invalid shaders/program/wobble.fsh: Couldn't compile fragment program: Fragment shader failed to compile with the following errors:
      Client> ERROR: 0:54: error(#160) Cannot convert from: "3-component vector of vec3" to: "highp 4-component vector of vec4"
      Client> ERROR: error(#273) 1 compilation errors.  No code generated
      Client> 	at bou.a(SourceFile:68) ~[13w42a.jar:?]
      Client> 	at bor.<init>(SourceFile:131) ~[13w42a.jar:?]
      Client> 	at bot.<init>(SourceFile:26) ~[13w42a.jar:?]
      Client> 	at bos.a(SourceFile:239) ~[13w42a.jar:?]
      Client> 	at bos.b(SourceFile:133) ~[13w42a.jar:?]
      Client> 	at bos.a(SourceFile:81) ~[13w42a.jar:?]
      Client> 	at bos.<init>(SourceFile:47) ~[13w42a.jar:?]
      Client> 	at blc.c(SourceFile:163) [13w42a.jar:?]
      Client> 	at bbm.a(SourceFile:93) [13w42a.jar:?]
      Client> 	at bbw.a(SourceFile:172) [13w42a.jar:?]
      Client> 	at bbw.d(SourceFile:236) [13w42a.jar:?]
      Client> 	at bbw.k(SourceFile:211) [13w42a.jar:?]
      Client> 	at ayw.o(SourceFile:1296) [13w42a.jar:?]
      Client> 	at ayw.ac(SourceFile:749) [13w42a.jar:?]
      Client> 	at ayw.e(SourceFile:700) [13w42a.jar:?]
      Client> 	at net.minecraft.client.main.Main.main(SourceFile:103) [13w42a.jar:?]
      Client> [00:07:18] [Client thread/INFO]: Selecting effect minecraft:shaders/post/fxaa.json
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              megascience LAN
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                CHK: