-
Bug
-
Resolution: Awaiting Response
-
None
-
24w46a
-
Windows 11, Java 21
-
Confirmed
-
(Unassigned)
When using an item model that changes based off the holder_type property checking for a player, the result is very inconsistent between various GUIs and screens in the game that render or hold items. Below is a table documenting the different screens/GUIs, whether or not items within them are considered as held by a player, whether or not this seems intended or correct, and any additional notes on the behavior.
Screen/GUI | Considered as held by a player? |
Likely to be correct? | Additional notes |
---|---|---|---|
Toasts | No | Yes | |
Advancements | No | Yes | |
Statistics | No | Yes | |
World Creation | No | Yes | |
Gamemode Switcher | Yes | No | Seems likely to be incorrect based on the other non-block UI screen behaviors. Not a tangible item, cannot be held. |
Recipe Book Tabs | No | Yes | Intangible item, cannot be held. |
Creative Menu tabs | Yes | No | Inconsistent with the recipe book tabs and other intangible items. |
Recipe Book recipes | Sometimes | Mixed results |
|
Crafting Table/Crafter input slots | Yes | Uncertain1 | |
Crafting Table/Crafter output slots | No | Uncertain1 | These are the only two cases where an output slot is not considered player held. |
Missing ingredient recipe displays | No | Yes | Not a tangible item, seems likely to be correct. |
All Anvil slots | Yes | Uncertain1 | |
All Brewing Stand slots | Yes | Uncertain1 | |
Beacon payment slot | Yes | Uncertain1 | |
Beacon payment example items | Yes | No | Not a tangible item, so unable to be held. |
All Furnace, Blast Furnace, and Smoker slots | Yes | Uncertain1 | |
All Loom slots | Yes | Uncertain1 | |
All Smithing Table slots | Yes | Uncertain1 | |
All Cartography Table slots | Yes | Uncertain1 | |
All Grindstone slots | Yes | Uncertain1 | |
Stonecutter | Yes | Mixed Results | The selectable recipes are not tangible items, but the input and output slots should follow note 1. Currently all three are considered player held. |
Items in Container blocks, such as Chests, Barrels, and Shulker boxes | Yes | Uncertain2 | |
Items in the equipment/storage slots of Horses, Mules, Donkeys, and Llamas | Yes | Uncertain2 | |
Items in the Bundle tooltip/preview | Yes | Uncertain, likely No | This one is a weird case because the item inside of the bundle isn't being held, the bundle is. |
Villager/Wandering Trader trades list | No | Yes | These items are unaffected by checking if the holder type is a Villager/Wandering Trader, but this may be intended depending on how note 1 is treated. |
Villager/Wandering Trader input/output slots | Yes | Uncertain1 |
1 - Entirely depends on if items placed in GUI slots still being considered as player held is intended behavior. If it is, then only crafting output slots are incorrect.
2 - Depends on if storage/container slots are intended to be treated differently from workstation GUI slots, due to the ability to close the gui and store the item permanently in the slot, unlike the ones covered by note 1.
Attached are screenshots of the cases listed in the chart. The item model being an apple means that it is considered player held, and the item model being a potato means that it is not. The resource pack used to test this is also attached - various random items were used to test the different cases, so refer to the files at assets/minecraft/items to see which are changed.
- relates to
-
MC-278317 Some entities don't count towards the "holder_type" property
- Open