The description on the wiki for 'generic.luck' says

"Affects the results of loot tables using the quality or bonus_rolls tag (e.g. when opening chests or chest minecarts, fishing, and killing mobs)."

But when changing the attribute it seems that chest loot remains the same, mob loot remains the same, and fishing stops working entirely.