Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-272606

Some sign render layer operations are performed twice

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Invalid
    • None
    • 1.21 Pre-Release 1
    • None
    • Plausible
    • (Unassigned)

      There exist two render layer methods returning the same sign render layer field. However, both methods are used within various rendering code, despite using the same render layer reference.

      These methods are in Yarn mappings:

      • TexturedRenderLayers#getSign
      • TexturedRenderLayers#getHangingSign

      The following methods perform duplicate work using both render layer methods:

      • BufferBuilderStorage constructor
      • WorldRenderer#render

      While duplicate work is being performed, the user impact is minimal because the methods short-circuit or create garbage-collected objects due to their implementations. Still, I believe this is a valid technical issue as there is a very minor performance penalty.

            Unassigned Unassigned
            haykam haykam
            Votes:
            3 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: