Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-258279

Particle groups aren't cleared on resource reload

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • 1.19.2, 1.19.3 Release Candidate 1
    • None
    • Operating System: Windows 10 (amd64) version 10.0
      Java Version: 17.0.1, Oracle Corporation
      JVM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Oracle Corporation
    • Plausible
    • Particles
    • Important
    • Platform

    Description

       

      When resource packs are reloaded, particles are also cleared in ParticleEngine as shown below in reload.

       

      this.particles.clear();
      profilerFiller2.startTick();
      profilerFiller2.push("upload");
      this.textureAtlas.reload(preparations);
      profilerFiller2.popPush("bindSpriteSets");

       

      However, this doesn't clear tracked particles, such as for the spore blossom, so no more particles in that specific group are able to be spawned until the world is reloaded.

      Clearing trackedParticleCounts when the particles are cleared solves the problem.

      this.particles.clear();
      + this.trackedParticleCounts.clear();
      profilerFiller2.startTick();
      profilerFiller2.push("upload");
      this.textureAtlas.reload(preparations);
      profilerFiller2.popPush("bindSpriteSets");

      The result of this fix is spore blossoms as well as any other particles (future, modded, etc.) still being able to emit particles after a resource reload.

       

      Attachments

        Issue Links

          Activity

            People

              SystemInvecklare [Mojang] SystemInvecklare
              Ocelot5836 Brandon Silva
              Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                CHK: