Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-257133

Desync when placing large paintings with NBT on a small space

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 1.19.2, 22w44a, 22w45a, 22w46a, 1.19.3, 23w06a, 1.19.4 Pre-release 2, 1.19.4 Pre-release 3, 1.19.4, 23w12a, 23w13a, 23w14a, 1.20 Pre-release 2, 1.20 Pre-release 4, 1.20 Pre-release 5, 1.20 Pre-release 6, 1.20 Release Candidate 1, 1.20, 1.20.1 Release Candidate 1, 1.20.1, 23w31a, 23w35a, 1.20.2 Pre-release 1, 1.20.2 Pre-release 2, 1.20.2 Pre-Release 3, 1.20.2 Release Candidate 1, 1.20.2 Release Candidate 2, 1.20.2, 23w40a, 23w41a, 23w42a, 23w43a, 23w44a, 23w45a, 23w46a, 1.20.3 Pre-Release 1, 1.20.3 Pre-Release 2, 1.20.3 Pre-Release 4, 1.20.3 Release Candidate 1, 1.20.3, 1.20.4 Release Candidate 1, 1.20.4, 23w51b, 24w03b, 24w04a, 24w05a, 24w06a, 24w07a, 24w09a, 24w10a, 24w11a, 24w12a, 24w13a, 24w14a, 1.20.5 Pre-Release 1, 1.20.5 Pre-Release 2, 1.20.5 Pre-Release 3, 1.20.5, 1.20.6, 24w18a, 24w20a, 24w21b, 1.21 Pre-Release 1, 1.21 Pre-Release 2, 1.21 Pre-Release 3, 1.21 Pre-Release 4, 1.21, 24w33a, 1.21.1, 24w35a, 24w36a, 24w37a, 24w38a, 24w39a, 24w40a, 1.21.2 Pre-Release 1, 1.21.2, 24w44a, 1.21.3
    • None
    • Confirmed
    • Items, Networking
    • Normal
    • Platform

      The bug

      When placing a painting with NBT in survival mode if the space you're trying to place it on is too small the painting will disappear from your inventory. You can get it back by either clicking on the slot in your inventory or reloading the world

      To reproduce

      1. Give yourself a painting item with NBT: 
        /give @p painting[entity_data={id:"minecraft:painting",variant:"minecraft:creebet"}] 1
      1. Try to place it on a block.

      Observed result

      The item "disappears" from the inventory, reappearing when the slot is clicked from the inventory.

      Expected result

      The placement would fail completely.

      Code analysis (as of 24w18a)

      Through the use of Spongepowered Mixins, I was able to come up with a fix, and that is to move line 75 (the "remove 1 from stack" line) of HangingEntityItem.java up a couple of lines into the "if is not client" code block where the placement sound is played

        1. 2024-05-23 15-11-14.mkv
          1017 kB
        2. 2024-05-23 15-27-42.mkv
          2.18 MB
        3. 2024-05-23 15-27-54.mkv
          2.22 MB

            Unassigned Unassigned
            MincraftEinstein MincraftEinstein
            Votes:
            16 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              CHK: