Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-250076

Shading is disabled for the two inner planes in mangrove roots, even though it isn't for all the other planes

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 22w14a
    • 22w17a
    • None
    • Community Consensus
    • Textures and models
    • Low

    Description

      Found while testing MC-250075, likely relates to MC-236474, may also relate to MC-249087

      The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.

      Download resource pack:

      The bug

      The two inner crossed planes which exist inside of mangrove roots have shading disabled, unlike all other parts of the block. This results in them appearing slightly different from the rest of the block; in general, they appear slightly brighter, and do not seem to be affected by smooth lighting to the extent they should be. This also appears to be the cause of the majority of MC-249087.

      This furthers my theory that the mangrove roots model was created by combining the existing "cross" model (with element rotations removed) with the powder snow model, as the cross model has shading disabled (MC-57159) whereas powder snow does not. As such, this introduces inconsistencies within the model which can be averted entirely by removing the "shade: false" limes from it.

      How to reproduce

      1. Place mangrove roots
      2. Look very closely at the inner planes

      Expected results

      The inner two planes would have the same brightness as the outer planes.

      Actual results

      The inner planes appear a tad lighter than the outer planes for a block in isolation, and tend to appear darker when the block is surrounded.

      How to fix

      This is a very easy fix - all of the '"shade": false' limes in the model should be deleted.

      Alternatively, the resource pack attached to this issue could be used instead, which also fixes MC-250075.

      Further notes

      The "inverse" of this fix (i.e. adding '"shade": false' to each element) can be used to fully fix MC-236474, a bug which should be reopened as it isn't actually a duplicate, and is just as easy of a fix as this is.

      Attachments

        1. 2022-04-09_20.25.09.png
          2022-04-09_20.25.09.png
          109 kB
        2. 2022-04-09_20.25.11.png
          2022-04-09_20.25.11.png
          156 kB
        3. 2022-04-09_20.25.16.png
          2022-04-09_20.25.16.png
          182 kB
        4. 2022-04-09_20.25.18.png
          2022-04-09_20.25.18.png
          242 kB
        5. 2022-04-09_20.25.23.png
          2022-04-09_20.25.23.png
          148 kB
        6. 2022-04-09_20.26.00.png
          2022-04-09_20.26.00.png
          178 kB
        7. 2022-04-11_18.27.42.png
          2022-04-11_18.27.42.png
          231 kB
        8. mangrove-roots-fix-22w16b-v1.0.zip
          1 kB

        Activity

          People

            wChi [Mojang] Chi Wong
            Awesoman3000 Connor Steppie
            Votes:
            4 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              CHK: