The bug

Allays do not check the dimension of the liked note block. If multiple dimensions have note blocks at the same coordinates, allays will deliver items to any of these.

Steps to Reproduce

1. Place note blocks in multiple dimensions at the same coordinates
2. Spawn an allay
3. Have it hold an item
4. (Optionally) run /data modify entity @e[type=minecraft:allay,limit=1] Brain.memories.minecraft:liked_noteblock_cooldown_ticks.value set value 100000 to increase cooldown for easier testing
5. Play the note block in one dimension
6. Teleport the allay to the other dimension e.g. via nether portals
7. Drop items and have the allay pick it up
8. Check whether the allay drops the items at the note block or the player

Expected Result

The allay will bring the item to the player, because the allay is linked to the note block in a different dimension.

Actual Result

The allay will drop the item at the note block.

Code Analysis

Code analysis by PR0CESS can be found in this comment.