Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-248847

The comma used to list colors within firework star item tooltips is untranslatable

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 1.18.1, 1.18.2 Release Candidate 1, 1.18.2, 1.19 Pre-release 1, 1.19, 1.19.1, 1.19.2, 22w43a, 22w45a, 1.19.3, 1.19.4, 1.20.1, 1.20.2, 1.20.3 Pre-Release 2
    • Confirmed
    • Internationalisation, Text
    • Low
    • Platform

      The Bug:

      The "," symbol that exists after every color within firework star item tooltips is untranslatable and is missing a translation key.

      Every language has its own rules that it follows. This ranges from spelling words differently, to using different punctuation under certain circumstances. Throughout the game, different languages can have symbols translated differently, therefore leading me to believe that this is a valid internationalization problem. For example, take the "options.controls" translatable text component which reads "Controls..." in English (US), and "按鍵設定⋯⋯" in Chinese Traditional, Hong Kong. As you can see the periods/full stops used within the Chinese Traditional, Hong Kong translation are completely different from the ones used in the English (US) translation. With this piece of knowledge in mind, some languages may interpret the use of the "," symbol differently.

      Steps to Reproduce:

      1. Attempt to search for the existence of this string by using this search filter on the official Minecraft crowdin project.
      2. Take note as to whether or not the comma used to list colors within firework star item tooltips is untranslatable.

      Observed Behavior:

      The comma used to list colors within firework star item tooltips is untranslatable.

      Expected Behavior:

      The comma used to list colors within firework star item tooltips would be translatable.

      Code Analysis:

      Code analysis by Avoma can be found below.

      The following is based on a decompiled version of Minecraft 1.18.1 using MCP-Reborn.

      net.minecraft.world.item.FireworkStarItem.java
      public class FireworkStarItem extends Item {
         ...
         private static Component appendColors(MutableComponent $mc, int[] $i) {
            for(int i = 0; i < $i.length; ++i) {
               if (i > 0) {
                  $mc.append(", ");
               }
               ...

      If we look at the above class, we can see that the comma used to list colors within firework star item tooltips is hardcoded, and as a result, is untranslatable. This is evident through the following piece of code:

      append(", ")

            Unassigned Unassigned
            Avoma [Mod] Avoma
            Votes:
            7 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              CHK: