Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-241933

Spore blossoms, cave vines, and pointed dripstones generate indented into the cave surface

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 1.18 Pre-release 1, 1.18 Pre-release 4
    • 1.18 Pre-release 5
    • None
    • Confirmed
    • (Unassigned)

    Description

      In 1.18 Pre-release 1, the Cave Surface decorator was removed and replaced with a specialized configuration of Environment Scan. However, the configuration used is incorrect in some cases and does not accurately replicate the old logic.

      The Bug

      As shown in the spore_blossom placed_feature:

      {
            "direction_of_search": "up",
            "target_condition": {
              "type": "minecraft:solid"
            },
            "allowed_search_condition": {
              "blocks": [
                "minecraft:air"
              ],
              "type": "minecraft:matching_blocks"
            },
            "max_steps": 12,
            "type": "minecraft:environment_scan"
          },

      The Solid predicate checks that the block to place in is a solid block. Since the loop ends and generates the feature when a solid block is found, the feature generates inside the block instead of below (or above) it. This affects spore blossoms, cave vines, and pointed dripstones and causes them to generate incorrectly.

       

      To reproduce
      Load the seed -7899173361933028793 and run /tp 58 36 314. Observe the incorrect spore blossom and cave vine.

       

      Solution

      Either an offset config should be added for the Solid predicate (to enable checking one block above or below), or a random_offset with a y offset of 1 or -1 should be added onto the end of the feature to compensate for the solid check.

      Attachments

        1. 2021-11-14_21.33.41.png
          2021-11-14_21.33.41.png
          461 kB
        2. 2021-11-14_21.34.08.png
          2021-11-14_21.34.08.png
          464 kB
        3. 2021-11-14_21.34.18.png
          2021-11-14_21.34.18.png
          466 kB
        4. 2021-11-18_22.47.04.png
          2021-11-18_22.47.04.png
          1.65 MB
        5. 2021-11-18 (6).png
          2021-11-18 (6).png
          530 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Starmute Starmute
              Votes:
              16 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                CHK: