Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-241742

Black signs cause more lag than colored signs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • None
    • 1.17.1, 1.18 Pre-release 2, 1.18 Pre-release 3, 1.18, 1.18.1 Pre-release 1, 1.18.1
    • Confirmed
    • Performance, Rendering

      Black signs get always rendered, no matter what, while colored signs stop getting re-rendered after a certain distance. This causes black signs to cause significantly more lag than colored signs. It is especially noticeable when using glow signs, which are more laggy than ordinary signs (see MC-226966). Bug about general sign lag is MC-5169 

      The shouldRender code in SignBlockEntityRenderer.java with yarn:

          private static boolean shouldRender(SignBlockEntity sign, int signColor) {
              if (signColor == DyeColor.BLACK.getSignColor()) {
                  return true;
              } else {
                  MinecraftClient minecraftClient = MinecraftClient.getInstance();
                  ClientPlayerEntity clientPlayerEntity = minecraftClient.player;
                  if (clientPlayerEntity != null && minecraftClient.options.getPerspective().isFirstPerson() && clientPlayerEntity.isUsingSpyglass()) {
                      return true;
                  } else {
                      Entity entity = minecraftClient.getCameraEntity();
                      return entity != null && entity.squaredDistanceTo(Vec3d.ofCenter(sign.getPos())) < (double)RENDER_DISTANCE;
                  }
              }
          } 

       

        1. black-sign.mp4
          1.93 MB
        2. red-sign.mp4
          2.20 MB

            Unassigned Unassigned
            Doyeon Ayy LMAO (Inactive)
            Votes:
            12 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: