Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-239268

End portals and end gateways use obsidian for block particles

XMLWordPrintable

    • Community Consensus
    • Particles

      The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) add the texture files and replace the affected vanilla model files with the contents of the resource pack.

      Download resource pack:

      The bug

      The block particles which are created by end portals and end gateways are that of the obsidian block. This was done as a fix for MC-48089, however the current behaviour is still technically incorrect, as end portals and end gateways are ultimately unrelated to obsidian. These particles can be observed either by breakign the block in Creative, or by falling on them from a height (MC-122547).

      A close relative of MC-1874, a ticket which should probably be split.

      How to reproduce

      1. Break a block of obsidian, and note how the particles look
      2. Break an end portal block in Creative mode (can be placed via /setblock ~ ~ ~5 minecraft:end_portal), and note that the particles look identical to the particles from obsidian
      3. Break an end gateway block in Creative mode (can be placed via /setblock ~ ~ ~5 minecraft:end_gateway), and note that the particles once again look identical to the particles from obsidian

      Expected behaviour

      The particles produced from breaking these blocks would look much more like the block itself.

      Actual behaviour

      The obsidian particles are used instead, which, while they appear dark like these portal blocks, do not match it.

      How to fix

      Bedrock Edition actually has dedicated textures for the breaking particles of these blocks. Due to this, fixing this is very simple: these textures just need to be added to the game, and the end portal and end gateway models made to point to these textures instead. (The truth is slightly more complex, as there existed no end gateway model, and the blockstates file simply pointed to the end portal model instead; fixing this was still not much of a challenge as the blockstates file for end gateways just needed to be repointed to the end gateway model, and said end gateway model created.)

      Worth noting is that the textures for these were 16x17 rather than the conventional 16x16 - as such, I have resized these textures to be 16x16 for use in game, but the original 16x17 textures remain in a subfolder if use of these is preferable.

      As with my other recent resource pack fixes, I have tried to make fixing this for a release in the game as streamlined as possible: all that needs done is moving the contents of the resource pack into the vanilla resources, replacing files where applicable, and either deleting the 16x17 texture subfolder and its contents (if the 16x16 textures are to be used) or replacing the textures with the 16x17 textures and deleting the now empty subfolder (if the 16x17 textures are to be used).

      Notes

      While this ticket could be considered a parity issue as a result of these textures existing and seeing use in Bedrock Edition, and probably an invalid parity issue due to these predating the 1.15 threshold, I consider the fact that obsidian particles being produced is the problem here, and the parity issue is secondary to it. (However, I have still added the vanilla-parity label, as many other parity issues which predate 1.15 such as MC-47660 also have it.)

      It is also worth noting that a very similar issue, MC-128234, has been fixed in the past: the conduit, a block that renders as an entity, originally used missing texture particles (like was the case in MC-48089), which was first fixed by changing them to use sand particles (analogously to how end portals and gateways currently use obsidian particles), and then fully fixed by giving conduits a dedicated texture for their block particles (which this ticket aims to do).

        1. portal-particle-fix-21w41a-v1.0.zip
          5 kB
        2. 2021-10-18_16.21.27.png
          2021-10-18_16.21.27.png
          414 kB
        3. 2021-10-18_16.21.16.png
          2021-10-18_16.21.16.png
          429 kB
        4. 2021-10-18_16.21.02.png
          2021-10-18_16.21.02.png
          413 kB
        5. 2021-10-18_16.20.51.png
          2021-10-18_16.20.51.png
          432 kB

            Unassigned Unassigned
            Awesoman3000 Connor Steppie
            Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: