I have made multiple datapacks with advancements for 1.17 to find that they simply don't work. In specific, advancements that have something to do with items don't work. As shown below...

{
"rewards":

{ "function": "koa_combat:regens/food/baked_potato" }

,
"criteria": {
"ate_potato": {
"trigger": "minecraft:consume_item",
"conditions": {
"item":

{ "item": "minecraft:baked_potato" }

}
}
}
}

 Whenever I eat ANY item I get this advancement?

I have also had other instance where I wanted to make an advancement which is granted whenever the player kills a Hoglin with a rabbit's foot but this advancement is granted whenever I kill a hoglin PERIOD. I made another where the player has to have a turtle helmet but to my surprise it was granted whenever the player got any item be it a turtle helmet or just a regular seed.