Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-236461

Crop template model is not prefixed with "template_"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • None
    • 1.17.1
    • Confirmed
    • Textures and models

      The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.

      Download resource pack:

      The bug

      The crop block model, which is functionally a template model due to only containing the block shape and being referenced by other models to apply textures, is not prefixed with "template_". This is unlike a multitude of other template models which the game uses, which are in fact prefixed with "template_".

      How to reproduce

      This is as easy as just navigating to the assets/minecraft/models/block directory and checking the file names.

      1. Open the game jar file using one's preferred method
      2. Check the model file of a block that uses the crop model, such as wheat_stage3.json
        1. Note that it references block/crop.json, and also note that it isn't prefixed with template_
      3. Check the model of a block such as a wall torch, anvil, chorus flower, ...
        1. Note that the model it references is prefixed with template_ due to the referenced model in question being a template model

      Expected and actual results

      The table below summarizes the expected file names for the models in question.

      Current name Expected name Notes
      crop.json template_crop.json  

      How to fix

      Fixing this is as simple as renaming crop.json to template_crop.json, and then repointing all model files that reference it to the new names. 23 different model files currently point to it, namely those used for carrots, potatoes, beetroots, wheat and nether wart. The resource pack attached to this issue contains fixed versions of all 23 of these issues as well as a renamed crop template model to accompany them, meaning these can be added to minecraft.jar in seconds to fix this issue.

      The pack also cleans up formatting for consistency.

      Other thoughts

      While fixing this issue I noticed another inconsistency within the game's assets: all five of the crops mentioned in this ticket use an "age" block state to track growth, however the texture and model files for these (as well as many other blocks with age values) use "stage" instead. Perhaps it would be worth renaming these to "age" to better fit the block states? I may report this separately in future with a fix attached, however this will probably not be for a while.

            Unassigned Unassigned
            Awesoman3000 Connor Steppie
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: