Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-235696

Carpet template model is not prefixed with "template_"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • None
    • 1.17.1
    • Confirmed
    • Textures and models

      The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.

      Download resource pack:

      The bug

      The carpet block model, which is functionally a template model due to only containing the block shape and being referenced by other models to apply textures, is not prefixed with "template_". This is unlike a multitude of other template models which the game uses, which are in fact prefixed with "template_".

      How to reproduce

      This is as easy as just navigating to the assets/minecraft/models/block directory and checking the file names.

      1. Open the game jar file using one's preferred method
      2. Check the model file of a block that uses the carpet model, such as green_carpet.json
        1. Note that it references block/carpet.json, and also note that it isn't prefixed with template_
      3. Check the model of a block such as a wall torch, anvil, chorus flower, ...
        1. Note that the model it references is prefixed with template_ due to the referenced model in question being a template model

      Expected and actual results

      The table below summarizes the expected file names for the models in question.

      Current name Expected name Notes
      carpet.json template_carpet.json  

      How to fix

      Fixing this is as simple as renaming carpet.json to template_carpet.json, and then repointing all model files that reference it to the new names. 17 different model files currently point to it, for the 16 dye colors, as well as moss carpets. The resource pack attached to this issue contains fixed versions of all 17 of these models as well as a renamed carpet template model to accompany them, meaning these can be added to minecraft.jar in seconds to fix this issue.

      The pack also cleans up formatting for consistency.

      Further notes

      Carpet itself references "block/thin_block", which itself is a template model. I would advise renaming this to "template_thin_block.json" for obvious reasons, and cleaning up everything else that references that, however such a recommendation is outwith the scope of this ticket at this time.

            Unassigned Unassigned
            Awesoman3000 Connor Steppie
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: