Description

When a player is in the spin attack from using a riptide trident they will attack any entity that they collide with. However, all entities in the bounding box are collided with even if they are in a scoreboard team with a collision rule that makes them uncollidable normally.

This is specifically annoying in non-pvp minigames where the riptide is used as a movement mechanic. Myself I've encountered this issue when making a race game where all racers are given a riptide trident. Even though damage is irrelevant and player collision is completely disabled (collisionRule is never for all teams and all racers are on a team) players will still collide while riptiding as the spin attack triggers.

Reproduction Steps

• Create a scoreboard team with `collisionRule` set to `never`
• Have multiple players that are on the team
• Use a riptide trident

Observed Results

The riptiding player will collide with the other player and be stopped.

Expected Results

The riptiding player keeps moving and is not interrupted.

Code Analysis

Currently the code running every tick while a player is in the spin attack gets all entities within the bounding box and attacks them. Instead it should filter out entities depending on whether they are collidable based on their scoreboard team.

If it helps I can provide the necessary code change that needs to be made to fix the issue.