Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-219892

Falling from cave vines and dying uses death.fell.accident.other_climbable, instead of a specified death message

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 21w11a, 21w13a, 21w14a, 21w15a, 21w16a, 21w17a, 21w18a, 1.17 Pre-release 1, 1.17 Release Candidate 1, 1.17, 1.17.1, 21w43a, 1.18 Pre-release 4, 1.18.1, 1.18.2, 22w12a, 22w14a, 22w15a, 22w17a, 1.19 Pre-release 2, 1.19, 1.19.1 Pre-release 6, 1.19.1, 1.19.2, 22w42a, 22w43a, 22w44a, 22w46a, 1.19.3 Pre-release 1, 1.19.3, 23w03a, 23w06a, 1.19.4 Pre-release 1, 1.19.4, 23w16a, 1.20 Pre-release 2, 1.20 Pre-release 5, 1.20 Pre-release 6, 1.20, 1.20.1, 23w32a, 23w35a, 1.20.2 Pre-release 1, 1.20.2 Release Candidate 1, 1.20.2, 23w41a, 23w42a, 23w43a, 23w44a, 1.20.3 Pre-Release 2, 1.20.3, 1.20.4, 24w07a, 24w09a, 24w10a, 24w12a, 24w13a, 1.20.5 Release Candidate 1, 1.20.5
    • None
    • Confirmed
    • Player, Text
    • Low
    • Gameplay

      The death message I got by falling from cave vines is "<player> fell while climbing"; it should be "<player> fell off some cave vines" or something along those lines.

      How to reproduce:

      1. Place a block at least 25 blocks above the ground using /setblock.
      2. Place two cave vines using glow berries below the block.
      3. Fly into and stay in the cave vines in creative mode.
      4. Switch to survival mode and let yourself fall and die.
      5. Look at the death message.

      What I expected to happen was:

      The death message would be something close to "<player> fell off some cave vines".

      What actually happened was:

      The death message was "<player> fell while climbing".

      Cause:

      Living entities have a CombatTracker, which tracks the details of damage recently taken. When taking damage, CombatTracker#recordDamage is run, which tracks the damage, and that method runs prepareForDamage, which checks for climbable blocks. That method does not contain a check for Blocks.CAVE_VINES or Blocks.CAVE_VINES_PLANT.

        1. 2021-03-17_14.54.47.png
          2021-03-17_14.54.47.png
          1.67 MB
        2. MC-219892.mp4
          3.10 MB
        3. MC-219892.png
          MC-219892.png
          331 kB

            Unassigned Unassigned
            ManosSef ManosSef
            Votes:
            13 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              CHK: