Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-217509

Inefficient generation of aquifers, noise caves and ore veins

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: 21w08b, 21w10a, 21w11a, 21w15a, 21w19a, 1.17
    • Fix Version/s: 21w37a
    • Labels:
      None
    • Confirmation Status:
      Confirmed
    • Category:
      Performance
    • Mojang Priority:
      Important

      Description

      The bug

      Worlds with ore veins, aquafiers and noise caves generate noticably slower

      1.17 data

      This data is generated using a script generating multiple empty worlds with the base settings height=4064, no terrain, void biome, same seed.
      See generationtime.txt for all data

      Average generation times:

      1.17-all disabled.json 27.19s = base
      1.17-noodle_caves_enabled.json 27.52s = +1%
      1.17-deepslate_enabled.json 27.77s = +2%
      1.17-noise_caves_enabled.json 36.76s = +35%
      1.17-aquifers+noise_caves_enabled.json 44.40s = +63%
      1.17-ore_veins_enabled.json 65.41 = +140%
      1.17-everything_enabled.json 80.00s = +194%

      OLD / 21W08B DATA

      Generating the given world configs both twice:

      everything_disabled_20w08b.jsonDeepslate, aquifers and noise caves disabled: 19.03 20.74 seconds
      deepslate_enabled_21w08b.jsonDeepslate enabled: 24.54 25.51 seconds
      aquafiers_enabled_21w08b.jsonAquifers enabled: 29.68 33.59 seconds

      noisecaves_enabled_21w08b.jsonNoisecaves enabled: 21.84 22.25 seconds
      everything_enabled_21w08b.jsonDeepslate, aquifers and noise caves enabled: 40.95 35.87

      Note: The custom world files' noise settings are based on the End islands, but taller. These settings have nothing to do with the inefficiency

      This might be handy, it's a commit optimising aquifers for the cubic chunks mod: https://github.com/OpenCubicChunks/CubicChunks/commit/3be75eb6ad77e5419a2f62ae9269cdf775a85fb1
       

       

        Attachments

        1. 1.17-all disabled.json
          3 kB
        2. 1.17-aquifers+noise_caves_enabled.json
          3 kB
        3. 1.17-deepslate_enabled.json
          3 kB
        4. 1.17-everything_enabled.json
          3 kB
        5. 1.17-noise_caves_enabled.json
          3 kB
        6. 1.17-noodle_caves_enabled.json
          3 kB
        7. 1.17-ore_veins_enabled.json
          3 kB
        8. aquafiers_enabled_21w08b.json
          6 kB
        9. deepslate_enabled_21w08b.json
          6 kB
        10. everything_disabled_20w08b.json
          6 kB
        11. everything_enabled_21w08b.json
          6 kB
        12. generationtime.txt
          2 kB
        13. image-2021-03-02-13-35-41-497.png
          image-2021-03-02-13-35-41-497.png
          26 kB
        14. noisecaves_enabled_21w08b.json
          6 kB

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            Tycho Los BBLZ
            Votes:
            14 Vote for this issue
            Watchers:
            15 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              CHK: