Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-173021

Unuseful warning is logged when server receives incorrect vehicle movement packets

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 20w08a
    • 20w10a
    • None
    • Confirmed
    • Debug
    • Low

    Description

      The bug

      When the server receives incorrect vehicle movement packets (ServerboundMoveVehiclePacket) it logs:

      LOGGER.warn("{} moved wrongly!", entity.getName().getString());
      

      where entity is the vehicle. This results in unuseful warnings messages like:

      Boat moved wrongly!
      

      It would be better if the message was similar to the one for too fast movement which includes the controlling player:

      LOGGER.warn("{} (vehicle of {}) moved too quickly! {},{},{}", entity.getName().getString(), this.player.getName().getString(), ...
      

      How to reproduce (vanilla)

      Can currently be seen when reproducing MC-172420

      Code analysis

      20w08a, Mojang names
      Method: net.minecraft.server.network.ServerGamePacketListenerImpl.handleMoveVehicle(ServerboundMoveVehiclePacket)

      Attachments

        Activity

          People

            Unassigned Unassigned
            marcono1234 [Mod] Marcono1234
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              CHK: